Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dictionary] Field level permissions #9495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[dictionary] Field level permissions #9495

wants to merge 1 commit into from

Conversation

skarya22
Copy link
Contributor

Brief summary of changes

  • Introduced field level permissions for the data dictionary, so that permissions for specific fields can be removed from users.
  • Capability is copied from Instrument Manager
    TODO:
  • Work with @driusan to make the dqt actually use this
  • Currently is saved by the parameter_type ID, however candidate level fields are not in parameter_type, not sure how to go around that.

@skarya22 skarya22 added the State: Needs work PR awaiting additional work by the author to proceed label Nov 29, 2024
@skarya22 skarya22 self-assigned this Nov 29, 2024
@maximemulder maximemulder added the Release: SQL patch PR that contains an SQL patch to apply label Dec 2, 2024
@skarya22 skarya22 mentioned this pull request Dec 3, 2024
Closed
driusan
driusan reviewed Dec 12, 2024
View reviewed changes
SQL/New_patches/2024-11-29-Dictionary-Field-Permissions.sql
@@ -0,0 +1,8 @@
CREATE TABLE `parameter_type_permissions_rel` (
`ParameterTypeID` int(10) unsigned NOT NULL,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no ParameterTypeID in the dictionary module. This needs to store Module and Fieldname.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driusan driusan driusan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@skarya22 skarya22

Labels
Release: SQL patch PR that contains an SQL patch to apply State: Needs work PR awaiting additional work by the author to proceed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skarya22 @driusan @maximemulder