Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[composer] manage project dependencies #9496

Merged
merged 4 commits into from
Dec 5, 2024
Merged

[composer] manage project dependencies #9496

merged 4 commits into from
Dec 5, 2024

Conversation

regisoc
Copy link
Contributor

@regisoc regisoc commented Dec 2, 2024

Brief summary of changes

  • Allow additional composer deps to be managed in project/ without the need to override the main composer.json.
  • Adds the documentation section to cover how to override LORIS.

Testing instructions (if applicable)

  1. create a project/composer.json with additional deps.
  2. run composer update

Related PR

Reopening #8319 as a new dependency is needed in HBCD.

@regisoc regisoc added Priority: Projects Project: HBCD Issue or PR related to the HBCD project labels Dec 2, 2024
@regisoc regisoc mentioned this pull request Dec 2, 2024
Closed
driusan
driusan requested changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@driusan driusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style cosistency

php/libraries/FeedbackMRI.class.inc Outdated Show resolved Hide resolved
modules/issue_tracker/php/edit.class.inc Outdated Show resolved Hide resolved
@regisoc regisoc requested a review from driusan December 2, 2024 17:10
@skarya22
Copy link
Contributor

skarya22 commented Dec 3, 2024

credits to @laemtl

@driusan driusan merged commit 92c4d81 into aces:26.0-release Dec 5, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driusan driusan Awaiting requested review from driusan

@jeffersoncasimir jeffersoncasimir Awaiting requested review from jeffersoncasimir

Assignees

@jeffersoncasimir jeffersoncasimir

Labels
Project: HBCD Issue or PR related to the HBCD project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@regisoc @skarya22 @driusan @jeffersoncasimir @maximemulder