Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EEG Browser] Fix webpack and ts config #9517

Merged
merged 1 commit into from
Dec 18, 2024
Merged

[EEG Browser] Fix webpack and ts config #9517

merged 1 commit into from
Dec 18, 2024

Conversation

laemtl
Copy link
Contributor

@laemtl laemtl commented Dec 18, 2024

Fix the webpack and TS config for EEG Browser:

  • disable TS strict mode for the EEG visualization module for successful compilation
  • remove unecessary webpack hack with proper ts config

@laemtl laemtl changed the base branch from main to 26.0-release December 18, 2024 00:08
maximemulder
maximemulder approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@maximemulder maximemulder left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine (though I'd like to know what was the problem, since this is labelled as a fix).

@laemtl
Copy link
Contributor Author

laemtl commented Dec 18, 2024

Works on my machine (though I'd like to know what was the problem, since this is labelled as a fix).

It was not compiling with TS strict mode. We had 400 ish errors.

@driusan driusan merged commit 03d4710 into aces:26.0-release Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximemulder maximemulder maximemulder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laemtl @maximemulder @driusan