Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webpack] Fix incorrect module overwrite #9653

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeffersoncasimir
Copy link
Contributor

@jeffersoncasimir jeffersoncasimir commented Feb 28, 2025

Closes #9646

Testing instructions:

  • Before pulling, experience the bug by doing the following:
  • Have a ./project/webpack-project.config.js file that exports nothing. entry = {}; -- It doesn't have to be empty, but make sure you're not overriding the module in the step below
  • Delete any module's js/* files; I used login.
  • npm run compile -- The js/* files will not get created.

After pulling, everything should compile as normal.

@jeffersoncasimir jeffersoncasimir added the 27.0.0 - Bugs Bugs Found in LORIS 27 testing label Feb 28, 2025
@regisoc regisoc added the Priority: High PR or issue should be prioritised over others for review and testing label Mar 3, 2025
@jeffersoncasimir jeffersoncasimir added this to the 27.0.0 milestone Mar 4, 2025
@racostas racostas self-requested a review March 7, 2025 18:44
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Woks as expected.

@racostas racostas added the Passed manual tests PR has been successfully tested by at least one peer label Mar 7, 2025
@jeffersoncasimir jeffersoncasimir added the Blocking PR should be prioritized because it is blocking the progress of another task label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
27.0.0 - Bugs Bugs Found in LORIS 27 testing Blocking PR should be prioritized because it is blocking the progress of another task Passed manual tests PR has been successfully tested by at least one peer Priority: High PR or issue should be prioritised over others for review and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[webpack] Issue with webpack-project.config.ts
3 participants