Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dictionary] Fix out of order cols #9669

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

skarya22
Copy link
Contributor

@skarya22 skarya22 commented Mar 5, 2025

Brief summary of changes

  • Dictionary module had issues with columns being out of order
  • Made the data displayed correctly by:
    • Separating visits into its own column for session level fields
    • Put enumeration data into the data type instead of a separate datapoint called options which was confusing
      image

Testing instructions (if applicable)

  1. Poke around the dictionary module, confirm that the filters for visits and cohorts work
  2. Confirm the enumeration options for enum fields are correct

Link(s) to related issue(s)

@skarya22 skarya22 added 27.0.0 - Bugs Bugs Found in LORIS 27 testing Module: dictionary PR or issue related to (new) dictionary module Priority: High PR or issue should be prioritised over others for review and testing 26.0.0-bugs Issues that were raised during the release testing for 26.0.0 labels Mar 5, 2025
@skarya22 skarya22 added this to the 27.0.0 milestone Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0 27.0.0 - Bugs Bugs Found in LORIS 27 testing Module: dictionary PR or issue related to (new) dictionary module Priority: High PR or issue should be prioritised over others for review and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dictionary] Cohort column contains strange values
1 participant