Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a "mkdir" utility module for Boutiques integrator #1343

Open
prioux opened this issue Aug 10, 2023 · 1 comment · May be fixed by #1348
Open

Create a "mkdir" utility module for Boutiques integrator #1343

prioux opened this issue Aug 10, 2023 · 1 comment · May be fixed by #1348
Assignees
Labels
Admin Features or bugs related to administrative features Boutiques Boutiques integration Enhancement

Comments

@prioux
Copy link
Member

prioux commented Aug 10, 2023

Some tools integrated with boutiques receive as an input a string which will be provided on the command line, and that string is supposed to point to an existing subdirectory. E.g.

"command-line":  "supertool -out [OUTDIR] [OPT] [OPT]..."

When integrating such tools in CBRAIN, they often expect the OUTDIR to be pre-existing, and the tool crash at run time.

Historically, we modified some of these descriptor within CBRAIN so the the command was changed to

"command-line": "mkdir -p [OUTDIR] ; supertool -out [OUTDIR] [OPT] [OPT]..."

But it's kind of ugly and it means the descriptor is no longer really as generic (usable outside CBRAIN as well as within).

I suggest we implement a new utility module where a CBRAIN dev can just leave the command-line intact, and specify which input argument to run mkdir on when setting up the task.

Something like:

"BoutiquesSubdirMaker": [ "output_dir", "someinputid2" ]
@prioux prioux added Enhancement Boutiques Boutiques integration Admin Features or bugs related to administrative features labels Aug 10, 2023
@prioux
Copy link
Member Author

prioux commented Aug 10, 2023

Maybe the values for the configuration could instead be templates, with values subsituted from any inputs. e.g.

"BoutiquesSubdirMaker": [ "[OUTDIR]", "[OUTDIR]/[THRESHOLD]_res" ]

That woudl make the module much more flexible.

@prioux prioux changed the title Create a "mkdir" utility module for Boutiques Create a "mkdir" utility module for Boutiques integrator Aug 10, 2023
@MontrealSergiy MontrealSergiy linked a pull request Sep 8, 2023 that will close this issue
@MontrealSergiy MontrealSergiy self-assigned this Sep 29, 2023
@MontrealSergiy MontrealSergiy linked a pull request Sep 29, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Features or bugs related to administrative features Boutiques Boutiques integration Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants