Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utility module make folders #1343 #1348

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

MontrealSergiy
Copy link
Contributor

see #1343 for details

@MontrealSergiy MontrealSergiy self-assigned this Sep 8, 2023
@MontrealSergiy MontrealSergiy added Enhancement Boutiques Boutiques integration Admin Features or bugs related to administrative features labels Sep 8, 2023
@prioux
Copy link
Member

prioux commented Sep 8, 2023

The code to make the directories should not be performed in a method that is meant to return a descriptor to the framework. It should be done in "setup", that's the proper place where everything related to preparing a work directory is supposed to happen.

Copy link
Member

@prioux prioux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments in code and one comment in main discussion

BrainPortal/lib/boutiques_dir_maker.rb Outdated Show resolved Hide resolved
@prioux
Copy link
Member

prioux commented Sep 11, 2023

Actually I double checked, the on-disk invoke struct is created during 'cluster_commands()' so that's the method you need to override instead of setup().

@MontrealSergiy
Copy link
Contributor Author

MontrealSergiy commented Sep 11, 2023

So do I keep old version (with minor improvements in variable names and plus of course), or should I avoid altering the command line and created subfolders directly instead?

@prioux
Copy link
Member

prioux commented Sep 11, 2023

Don't modify the command line. Just writ the ruby code that run the mkdir. That's it.

@MontrealSergiy
Copy link
Contributor Author

ok. Another possibility is to factor out invocation struct massaging into separate method, so setup can be used

@MontrealSergiy
Copy link
Contributor Author

Done.

(adjusted to create subfolders asap)

@MontrealSergiy MontrealSergiy changed the base branch from master to dev September 18, 2023 18:45
@MontrealSergiy MontrealSergiy linked an issue Sep 29, 2023 that may be closed by this pull request
@MontrealSergiy
Copy link
Contributor Author

As agreed in person with Pierre, the method cluster_commands() is modified (but in a more complex way than at the first attempt)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Features or bugs related to administrative features Boutiques Boutiques integration Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a "mkdir" utility module for Boutiques integrator
2 participants