-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utility module make folders #1343 #1348
base: dev
Are you sure you want to change the base?
Conversation
The code to make the directories should not be performed in a method that is meant to return a descriptor to the framework. It should be done in "setup", that's the proper place where everything related to preparing a work directory is supposed to happen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments in code and one comment in main discussion
Actually I double checked, the on-disk invoke struct is created during 'cluster_commands()' so that's the method you need to override instead of setup(). |
So do I keep old version (with minor improvements in variable names and plus of course), or should I avoid altering the command line and created subfolders directly instead? |
Don't modify the command line. Just writ the ruby code that run the mkdir. That's it. |
ok. Another possibility is to factor out invocation struct massaging into separate method, so setup can be used |
Done. (adjusted to create subfolders asap) |
As agreed in person with Pierre, the method cluster_commands() is modified (but in a more complex way than at the first attempt) |
see #1343 for details