-
Notifications
You must be signed in to change notification settings - Fork 51
utility module make folders #1343 #1348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a541a32
mkdir boutiques module
MontrealSergiy a69bcce
DirMaker link
MontrealSergiy f850e3e
correct soft link for dir maker
MontrealSergiy 2c9fff4
fail absolute path mkdir
MontrealSergiy dbec2aa
mkdir module - add quotes over paths to handle spaces etc
MontrealSergiy 2cec554
mkdir boutiques module - create folders right away rather than modify…
MontrealSergiy ec82430
addressed skips in makedir
MontrealSergiy ce0ea99
bugfix makedir
MontrealSergiy 5bed214
move super to top, drop early exit
MontrealSergiy 7308543
replace mkdir -p with safe_mkdir, verbiage etc..
MontrealSergiy 31c3f22
improve logging, addresses versions without this boutiques with an e…
MontrealSergiy 39ebdcc
shorten docs for boutiques_dir_maker
MontrealSergiy 95abdad
docs, grammar and style improvements boutiques_dir_maker
MontrealSergiy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../../BrainPortal/lib/boutiques_dir_maker.rb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,88 @@ | ||
|
||
# | ||
# CBRAIN Project | ||
# | ||
# Copyright (C) 2008-2025 | ||
# The Royal Institution for the Advancement of Learning | ||
# McGill University | ||
# | ||
# This program is free software: you can redistribute it and/or modify | ||
# it under the terms of the GNU General Public License as published by | ||
# the Free Software Foundation, either version 3 of the License, or | ||
# (at your option) any later version. | ||
# | ||
# This program is distributed in the hope that it will be useful, | ||
# but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
# GNU General Public License for more details. | ||
# | ||
# You should have received a copy of the GNU General Public License | ||
# along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
# | ||
|
||
|
||
# Some tools expect that a directory e.g. results, etc exists in the working directory | ||
# | ||
# While in a descriptor's command line can include a prefix 'mkdir -p DIRNAME;' for that purpose, | ||
# creating multiple directories makes the command line harder to read and maintain. | ||
# | ||
# This utility # allows the creation auxiliary sub-directories without using command line. | ||
# | ||
# The the `cbrain:integrator_modules` section look like: | ||
# | ||
# "cbrain:integrator_modules": { | ||
# "BoutiquesDirMaker": [ | ||
# "[OUTDIR]", | ||
# "[OUTDIR]/[THRESHOLD]_res", | ||
# "[OUTDIR]/[THRESHOLD]_res/info", | ||
# "tmp" | ||
# ] | ||
# | ||
# Please avoid single or double dots, spaces and special characters, except underscore and hyphen. | ||
# Use relative paths only. | ||
# | ||
# Boutiques templates (aka patterns) are supported and always substituted. | ||
# | ||
# Nested directories should be created step by step, as demonstrated with [OUTDIR]/[THRESHOLD]_res/info | ||
# in the snippet above. | ||
|
||
module BoutiquesDirMaker | ||
|
||
# Note: to access the revision info of the module, | ||
# you need to access the constant directly, the | ||
# object method revision_info() won't work. | ||
Revision_info=CbrainFileRevision[__FILE__] #:nodoc: | ||
|
||
############################################ | ||
# Bourreau (Cluster) Side Modifications | ||
############################################ | ||
|
||
# create few sub directories in the work folder | ||
def cluster_commands #:nodoc: | ||
# invoke overridden method | ||
commands = super | ||
|
||
descriptor = self.descriptor_for_setup | ||
patterns = descriptor.custom_module_info('BoutiquesDirMaker') | ||
return commands if patterns.blank? | ||
|
||
# Log revision information | ||
commit = Revision_info.short_commit | ||
self.addlog("Creating auxiliary directories with BoutiquesDirMaker rev. #{commit}.") | ||
|
||
substitutions_by_token = descriptor.build_substitutions_by_tokens_hash( | ||
JSON.parse(File.read(self.invoke_json_basename)) | ||
) | ||
|
||
# Process each directory pattern | ||
patterns.each do |pattern| | ||
path = descriptor.apply_substitutions(pattern, substitutions_by_token) | ||
path = path.strip # whitespaces in dir names are not supported | ||
path = Pathname.new(path.strip).cleanpath # normalizing: removing unnecessary dots ... | ||
cb_error "BoutiquesDirMaker cannot create path '#{path}' (pattern '#{pattern}')." if path.to_s.start_with?('.') | ||
safe_mkdir(path) | ||
MontrealSergiy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
self.addlog("BoutiquesDirMaker created '#{path}'.") | ||
end | ||
commands | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.