Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows package: does not include zmq dll when comma built with zmq #27

Open
junderwood opened this issue Jan 29, 2014 · 5 comments
Open
Labels

Comments

@junderwood
Copy link

As a result the current windows pre-built package was broken I believe.
I've rebuilt comma without zmq, and re-uploaded that under the same version number as was hosted before, but ultimately this should be fixed to work with zmq on.

@vlaskine
Copy link

did it ever work with zmq on windows?

@junderwood
Copy link
Author

honestly not sure... it built! ;)
... no reason to doubt it as such, zmq installed easily on win and snark built easily with it.
It was so long ago I can no longer remember which app prompted me to build it.

@junderwood
Copy link
Author

The cmake fix for win is trivial (just copy paste from how cmake includes opencv dlls at the bottom of the primary cmakelists.txt file... but I haven't had time so I re-uploaded the packages with zmq turned off. If one of your team has win installed, it's probably a 5 min job.

@vlaskine
Copy link

that's the problem: "if"... we don't do no windows... i will try to ask Thomas tomorrow, but i hate to say you may be the best candidate to fix it...

@junderwood
Copy link
Author

That may be the case. If it's more than a five minute job, might be best to leave it for now, as nobody is hanging on it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants