-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add some tests and QOL improvements #9
base: main
Are you sure you want to change the base?
Conversation
@achael ready for review and to be merged. tests are pretty general and pass on three of the machines I have access to including a macbook, personal linux box, and server |
hi @gnwong sorry I never merged this -- I took a look and there are quite a few conflicts with the newest version -- would you like me to go through them and try to merge or do you want to take a quick look and see if you can implement the tests relative to the latest version? |
Hi @achael . I don't think I'll be able to go through and check things carefully this week, but if you happen to have the time and propose how to resolve the merge conflicts I could definitely look through that. Otherwise I'm afraid it'll have to wait... |
Ready to be merged.
Tests can be run from root directory of repository with pytest (may need to
pip install pytest
)Also modified some formatting here and there throughout the code to improve readability. No functionality / logic changed.