Skip to content

Commit

Permalink
feat: Add owner field to Entity and rename labels to tags
Browse files Browse the repository at this point in the history
* Add owner field to Entity and rename labels to tags

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Change all entities in tests to reference tags instead of labels

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Add deprecation warning for labels argument

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
  • Loading branch information
felixwang9817 authored Feb 24, 2022
1 parent 0af8adb commit 412d625
Show file tree
Hide file tree
Showing 7 changed files with 143 additions and 223 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,12 @@ public static EntityProto.EntitySpecV2 createEntitySpecV2(
String name,
String description,
ValueProto.ValueType.Enum valueType,
Map<String, String> labels) {
Map<String, String> tags) {
return EntityProto.EntitySpecV2.newBuilder()
.setName(name)
.setDescription(description)
.setValueType(valueType)
.putAllLabels(labels)
.putAllTags(tags)
.build();
}

Expand Down
5 changes: 4 additions & 1 deletion protos/feast/core/Entity.proto
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,10 @@ message EntitySpecV2 {
string join_key = 4;

// User defined metadata
map<string,string> labels = 8;
map<string,string> tags = 8;

// Owner of the entity.
string owner = 10;
}

message EntityMeta {
Expand Down
Loading

0 comments on commit 412d625

Please sign in to comment.