forked from feast-dev/feast
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Respect specified ValueTypes for features during materialization (fea…
…st-dev#1906) * assert float feature is still float from online store Signed-off-by: Jeff <jeffxl@apple.com> * ensure float features retain float type from online store Floats were converted to doubles when materialized to the online store. There is a broader bug trend around type conversions and this particular conversion utility function looks like it could use some cleanup. This commit is a quick fix. Signed-off-by: Jeff <jeffxl@apple.com> * make fix more general Signed-off-by: Achal Shah <achals@gmail.com> * Use assertAlmostEquals Signed-off-by: Achal Shah <achals@gmail.com> * format Signed-off-by: Achal Shah <achals@gmail.com> * Support pandas timestamps correctly Signed-off-by: Achal Shah <achals@gmail.com> * Support pandas timestamps correctly Signed-off-by: Achal Shah <achals@gmail.com> * Correct import Signed-off-by: Achal Shah <achals@gmail.com> Co-authored-by: Achal Shah <achals@gmail.com>
- Loading branch information
Showing
3 changed files
with
31 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters