Skip to content
This repository has been archived by the owner on Aug 10, 2023. It is now read-only.

support speaking answers with 'say' and multiline input #4

Merged
merged 4 commits into from
Dec 4, 2022

Conversation

scottleibrand
Copy link
Contributor

If you'd like me to pick out some but not all of these changes, LMK and I'd be happy to break them apart.

Using this and Apple Dictation (after installing the Spanish Language in Dictation under Keyboard Preferences), I am able to practice my spoken Spanish using python3 ./revChatGPT.py say -v Paulina -r 200.

Copy link
Owner

@acheong08 acheong08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The say command is MacOS specific. I would like this to work on all platforms.

Multi-line input would be appreciated though.

@scottleibrand
Copy link
Contributor Author

The way I implemented it (but haven't documented yet) is to require the user to specify the extra command they want run on each response on the command line. So if there is a similar command on other platforms, they'd provide that command and its desired arguments as arguments to revChatGPT.py instead of say and its arguments. And if someone wanted to run a command to dump the responses to a database or something, they could easily do that too.

@scottleibrand
Copy link
Contributor Author

image

Copy link
Owner

@acheong08 acheong08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that is the case, the arguments such as -r 400 shouldn't be hard coded. I think it would be better to allow users to define a custom processor via the config file. For example, under a processor key, allow the user to define a command which is run every time an output is returned.

@scottleibrand
Copy link
Contributor Author

Ah, good point, yeah. I'll pull that part out for now, and then we can improve the UX later.

Copy link
Owner

@acheong08 acheong08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for temporary use

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants