Skip to content
This repository has been archived by the owner on Aug 10, 2023. It is now read-only.

Avoid unnecessary unescaping for httpx #898

Merged
merged 1 commit into from
Feb 25, 2023
Merged

Avoid unnecessary unescaping for httpx #898

merged 1 commit into from
Feb 25, 2023

Conversation

wenLiangcan
Copy link
Contributor

@wenLiangcan wenLiangcan commented Feb 25, 2023 •
edited
Loading

Seems httpx could just properly deal with back-slashes, unescaping would break the JSON (the issue was observed at here).

acheong08
acheong08 approved these changes Feb 25, 2023
View reviewed changes
Copy link
Owner

@acheong08 acheong08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python requests is weird for not doing that. I spent extremely long debugging with requests so I thought the same applied here

@acheong08 acheong08 merged commit 324f0d7 into acheong08:main Feb 25, 2023
acheong08 pushed a commit that referenced this pull request Feb 28, 2023
@wenLiangcan
Avoid unnecessary unescaping for httpx (#898)
f03a4dc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acheong08 acheong08 acheong08 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wenLiangcan @acheong08