fix: workaround hugomrdias/playwright-test#52 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
achingbrain
approved these changes
Aug 14, 2020
|
Hopefully @hugomrdias can take a look at why this is necessary.. |
achingbrain
added a commit
that referenced
this pull request
Sep 2, 2020
This pull request does following: - Adds JSDoc type annotations across the board - Adds `npm run check` command that runs a type checker. - Adds type checking phase to the CI - Adds the `npm run build` and `npm run build:types` scripts that generate `.d.ts` files in `dist`. - Updates naming / wording to reflect the fact that functions operate on iterables instead of iterators. - Adds `typesVersions` field to `package.json` so that programs that install these libraries will get types out of the box. - Fixes the issue that TS uncovered in `it-multipart` (error was swallowed) - Adds `.npmignore` which doesn't ignore `package/*/dist` directories so they are published with a package. This also cherry-picks #11 to overcome playwright-test issues Co-authored-by: Alex Potsides <alex@achingbrain.net>
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.