MdePkg: Convert new normal debug info to separate struct #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed by PM with @mhaeuser, it seems preferable to increment (or at least change to something else?) this value, in order that existing debug tools encountering the new format can reject it, and so that new debug tools can reliably detect when the new debug info fields are present. |
mikebeaton
force-pushed
the
image-info-type
branch
from
2900662 to
3d6ad6e
Compare
mhaeuser
reviewed
Nov 26, 2023
mikebeaton
force-pushed
the
image-info-type
branch
from
3d6ad6e to
0698ca1
Compare
MikhailKrichanov
approved these changes
Nov 27, 2023
|
|
mikebeaton
force-pushed
the
image-info-type
branch
4 times, most recently
from
622a56d to
3e6fb77
Compare
mikebeaton
changed the title
mikebeaton
force-pushed
the
image-info-type
branch
2 times, most recently
from
a908d1d to
3b1a9fd
Compare
mikebeaton
commented
Nov 28, 2023
|
@mhaeuser - I think it needed these slightly more extensive changes to match the what we discussed by PM. Does this look about right? (At least modulo the two comments I've added now.) |
mikebeaton
commented
Nov 28, 2023
mikebeaton
force-pushed
the
image-info-type
branch
2 times, most recently
from
c95e9b8 to
31fd8e7
Compare
mikebeaton
commented
Nov 29, 2023
mikebeaton
force-pushed
the
image-info-type
branch
from
31fd8e7 to
66cd139
Compare
|
I think I've got there now. Is someone able to scan through and re-check? |
mikebeaton
force-pushed
the
image-info-type
branch
from
66cd139 to
17246a9
Compare
MikhailKrichanov
approved these changes
Nov 30, 2023
mikebeaton
force-pushed
the
image-info-type
branch
from
17246a9 to
de22509
Compare
mikebeaton
force-pushed
the
image-info-type
branch
from
de22509 to
948e8e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention here is to enable old tools encountering the new standard format to understand that they don't understand the layout.
This will break old tools in situations where they could have worked, i.e. where what is loaded is in fact a PE, but it seems preferable to allow new tools, which are aware of the new structure fields, to reliably detect and access these whenever they are present.