Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After the update of VoodooPS2, there is a problem with the light of the caps lock. #514

Closed
ghost opened this issue Oct 13, 2019 · 25 comments

Comments

@ghost
Copy link

ghost commented Oct 13, 2019

As I said, when I use VoodooPS2Controller-2.0.3-RELEASE, the light of the caps lock button work normally.
After I installed VoodooPS2Controller-2.0.4-RELEASE, when I switch between upper and lower case, the light flashes briefly and then no longer lights up.
Please confirm if the update caused a new problem.
I can provide a log to help solve it, but I don't know how to do it.
PS:I am using Open-Core 0.5.2 with macOS 10.15.

@Andrw0830
Copy link

I can confirm same issue on my Dell Inspiron 7567 with same OpenCore version.

@ameenjuz
Copy link

Exact i have same issue caps lock light on VoodooPS2Controller-2.0.4-RELEASE didn't seem such issue to earlier VoodooPS2Controller-2.0.3-RELEASE

@vit9696
Copy link
Contributor

vit9696 commented Oct 14, 2019

Hmm, the thing is, this is a tradeoff between having working led and having working keyboard switch. See this issue: #435. To my eyes it is a lot more important to have #435 fixed than care about the LED.

CC @frol, @usr-sse2

@corint1
Copy link

corint1 commented Oct 14, 2019

same issue on Lenovo Ideapad 530S

@frol
Copy link

frol commented Oct 14, 2019

Without the fix I submitted my CapsLock Light worked, but there was no effect at all (and even worse, Karabiner reported stuck key with a semipermanent notification). The fix solved the functionality issue and the light works correctly for me.

@ghost
Copy link
Author

ghost commented Oct 14, 2019

Anyway, I think it's not realistic to adapt a driver to all models. But I have already rolled back to the previous version, and now everything works great.

@ghost
Copy link
Author

ghost commented Oct 14, 2019

Hmm, the thing is, this is a tradeoff between having working led and having working keyboard switch. See this issue: #435. To my eyes it is a lot more important to have #435 fixed than care about the LED.

CC @frol, @usr-sse2

However, I think the problem with led lights has caused me a lot of trouble. I often don't know if I am in uppercase or lowercase. And the previous version of the case switching function is great, I like it. And it is not very important to me to use the Caps Lock key to change input source.After all, we can use ctrl+space to switch it. Disable the case switch mode of Caps Lock key in the System Preferences tab.

@frol
Copy link

frol commented Oct 14, 2019

For me (Lenovo Y50-70) the caps lock didn’t work at all (well, except the light indicator) with the previous workaround. I wonder if you need any of the two workarounds at all.

@frol
Copy link

frol commented Oct 17, 2019

It seems that some of the hardware is not broken and do not need any of the workarounds (neither the old one nor the current one), so it might be reasonable to put the workaround behind a boot flag.

@DrConflict
Copy link

I have a problem with the caps lock with my wireless keyboard since updating to Catalina and OC 0.5.2.
So I'm not totally sure this is related to VoodooPS2 though.

@ghost
Copy link
Author

ghost commented Oct 21, 2019

I have a problem with the caps lock with my wireless keyboard since updating to Catalina and OC 0.5.2.
So I'm not totally sure this is related to VoodooPS2 though.

Roll back to the previous version (v2.0.3), have a try.

@DrConflict
Copy link

I have a problem with the caps lock with my wireless keyboard since updating to Catalina and OC 0.5.2.
So I'm not totally sure this is related to VoodooPS2 though.

Roll back to the previous version (v2.0.3), have a try.

I never used voodoops2 before though since I have no trackpad..

@JayMonkey
Copy link

Confirmed ... same issue on 2017 HP Spectre X360 laptop running VoodooPS2 2.0.4 RELEASE Version.

Caps lock key works as expected (toggles Upper/Lower case) but the led to indicate that Caps Lock is ON only flashes briefly and does not stay lit.

Issue did not occur with VoodooPS2 2.0.3 RELEASE Version

Cheers
Jay

@DrConflict
Copy link

DrConflict commented Nov 3, 2019

Caps lock light works again with BT keyboards now it seems. Not sure if this is because of the new OC and ASP packages or because of the new Catalina 10.15.1. Can anyone else confirm the issue is resolved for them as well since updating to the latest RELEASE packages and 10.15.1? I am NOT using VoodooPS2 kext though.

@hameerabbasi
Copy link

I can confirm this a bug in 10.15.0 and fixed in 10.15.1, and not related to Voodoo at all. My USB keyboard had the same issue, and the update was what fixed it without any other changes.

@JayMonkey
Copy link

I can confirm this a bug in 10.15.0 and fixed in 10.15.1, and not related to Voodoo at all. My USB keyboard had the same issue, and the update was what fixed it without any other changes.

@hameerabbasi ,

That is not the case for me ..

I was already running MacOS Catalina 10.15.1 with VoodooPS2 version 2.0.3 (release ver) installed and the caps lock LED was working fine. Once i installed VoodooPS2 version 2.0.4 the issue with the Caps Lock LED started.

If I switch back to VoodooPS2 2.0.3 the issue goes away and the Caps Lock LED works as expected.
Reinstall VoodooPS2 2.0.4 and the issue comes back ... pretty conclusive.

All tests done on 2017 15" HP Spectre X360 laptop running MacOS Catalina 10.15.1

Why are you using VoodooPS2 with a USB keyboard ?, it wont do anything ....

Cheers
Jay

@hameerabbasi
Copy link

I'm not. I just meant to show that a similar (though perhaps not the same) bug existed in 10.15.0.

@benbender
Copy link

benbender commented Nov 23, 2019

For my Thinkpad T480 with Mojave 10.14.6, the capslock-key is just sending 3a=39:

2019-11-23 00:22:20.050047+0000 0x18f      Default     0x0                  0      0    kernel: (VoodooPS2Keyboard) ApplePS2Keyboard: sending key 3a=39 down
2019-11-23 00:22:20.273484+0000 0x18f      Default     0x0                  0      0    kernel: (VoodooPS2Keyboard) ApplePS2Keyboard: sending key 3a=39 down
2019-11-23 00:22:20.441980+0000 0x18f      Default     0x0                  0      0    kernel: (VoodooPS2Keyboard) ApplePS2Keyboard: sending key 3a=39 down
...

acidanthera/VoodooPS2@7a4d7fb changed exactly that case and introduced the problems.

A simple solution could be to make the workaround configurable.
Would love to see that fixed and great love for all your great work! :)

@davithkb
Copy link

davithkb commented Dec 2, 2019

Same issue on dell xps 9370

@benbender
Copy link

For the time being, here is a fresh build from VoodooPS2-Master with reverted caps-lock-"fix":
VoodooPS2Controller-2.1.0-RELEASE.zip

@JayMonkey
Copy link

Small update on this issue from me ...

Yesterday I Updated to VoodooPS2 V2.1 + VoodooInput V1.0.1 (master release versions) and the Caps-Lock LED issue first seen in VoodooPS2 V1.0.4 remains.

Have just Installed the test version of VoodooPS2 V2.1 from above post with reverted caps-lock fix and the issue has gone away ... Caps Lock LED now works as expected.

Thanks for taking the time to look into it and give us a temporary fix ... at least it gives us a chance to test the improved three finger support in VoodooPS2 version 2.1, hopefully the issue will get fully addressed in the next release.

Maybe some sort of config flag could be added to the info.plist enable the Caps-Lock-Fix on laptops that need it ....

Cheers
Jay

@usr-sse2
Copy link
Contributor

usr-sse2 commented Dec 4, 2019

VoodooPS2Keyboard doesn’t change between versions, you can use newer VoodooPS2Trackpad with older VoodooPS2Keyboard

Sent with GitHawk

@benbender
Copy link

For the time being, here is a new, fresh build of VoodooPS2-Master & VoodooInput-Master with reverted caps-lock-"fix":
VoodooPS2Controller.kext+VoodooInput.kext-MASTER-Release.zip

@TiagoDamascena
Copy link

TiagoDamascena commented Jan 3, 2020

On my ASUS X512FA the caps lock indicator works on 2.0.4 but not work with 2.1.0 with VoodooInput 1.0.1.

EDIT: After change my bootloader to Opencore the LED stopped working with 2.04 and 2.1.0, only working with 2.0.3 on macOS Mojave.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

14 participants