Fix Caps Lock LED not working properly.

[Goshin]

Hi,

#3 fixed the Caps Lock functionality, but the LED still works in a strange way.

The LED is always lighted when the caps lock is pressed and turns off when it is released, just like a blink.

In the log:

kernel: (kernel) ApplePS2Keyboard: Caps Lock goingDown: 0x1 # pressed
kernel: (kernel) ApplePS2Keyboard: setAlphaLockFeedback locked:0x1 # turn on LED, should be ignored
kernel: (kernel) ApplePS2Keyboard: setAlphaLockFeedback locked:0x1 # This is the true state change.
kernel: (kernel) ApplePS2Keyboard: Caps Lock goingDown: 0x0 #released
kernel: (kernel) ApplePS2Keyboard: setAlphaLockFeedback locked:0x0 # turn off LED, should be ignored

The true state change for LED was overridden in the period.

This fix is to ignore the LED changes after caps lock key going down and going up.
It should work for both a long press and a short press when changing caps state and input source.

Note that there seems to be a system bug for Catalina. The caps state LED doesn't work sometimes. You may need to toggle (enable and disable) the option in Keyboard -> Input Sources -> Use the Caps Lock key to switch ....

[usr-sse2]

Thank you for your excellent work! This fix works correctly in both language switching and caps lock modes, even when swapping Caps Lock with some other modifier key like Control.
Please fix the spelling in your code before I merge this pull request (_ignoreCapsLedChagnge should be spelled _ignoreCapsLedChange, without extra g).

[vit9696]

Looks like there is still one more left:
https://travis-ci.com/acidanthera/VoodooPS2/jobs/280374759#L196

[vit9696]

REF: acidanthera/bugtracker#514

[Goshin]

Looks like there is still one more left:
https://travis-ci.com/acidanthera/VoodooPS2/jobs/280374759#L196

@usr-sse2 @vit9696
Thank you so much for your careful review.

[Mateo1234454545]

Problem still exists on latest release.

[Goshin]

Problem still exists on latest release.

Use the debug kext and see if you can get some log when switching the caps lock.

[Mateo1234454545]

Problem still exists on latest release.

Use the debug kext and see if you can get some log when switching the caps lock.

[Goshin]

@Mateo1234454545
Well, it seems the debug version does not define the DEBUG_MSG Marco, so it does not print the log we want. Try this one:

VoodooPS2Controller-2.1.1-RELEASE.zip

btw what is your OS version?

[Mateo1234454545]

Will try tomorrow.
I'm on Catalina 10.15.3

[Mateo1234454545]

Problem is more obvious on Big Sur.
Hope someone fixes it soon.