Avoid: Coroutine couldn't be started because the the game object 'Cur…

…ves' is inactive!
acidbubbles · Oct 30, 2022 · 1cca19e · 1cca19e
1 parent 3a9ee2b
commit 1cca19e
Showing 1 changed file with 14 additions and 1 deletion.
diff --git a/src/UI/Components/Curves/Curves.cs b/src/UI/Components/Curves/Curves.cs
@@ -20,6 +20,7 @@ public class Curves : MonoBehaviour
  private readonly List<ControllerLineDrawer3D> _lines3D = new List<ControllerLineDrawer3D>();
  private AtomAnimationEditContext _animationEditContext;
  private float _lastClipTime;
+ private Coroutine _drawCurvesCo;
 
  public Curves()
  {
@@ -216,6 +217,11 @@ private void OnEnable()
  private void OnDisable()
  {
  DestroyDeps();
+ if (_drawCurvesCo != null)
+ {
+ StopCoroutine(_drawCurvesCo);
+ _drawCurvesCo = null;
+ }
  }
 
  private void CreateDeps(ICurveAnimationTarget target)
@@ -323,7 +329,13 @@ private void DestroyDeps()
 
  private void OnAnimationKeyframesRebuilt()
  {
- StartCoroutine(DrawCurveLinesDeferred());
+ if (!isActiveAndEnabled) return;
+ if (_drawCurvesCo != null)
+ {
+ StopCoroutine(_drawCurvesCo);
+ _drawCurvesCo = null;
+ }
+ _drawCurvesCo = StartCoroutine(DrawCurveLinesDeferred());
  }
 
  private IEnumerator DrawCurveLinesDeferred()
@@ -332,6 +344,7 @@ private IEnumerator DrawCurveLinesDeferred()
  yield return 0;
  yield return 0;
  DrawCurveLinesImmediate();
+ _drawCurvesCo = null;
  }
 
  private void DrawCurveLinesImmediate()