feat(@typescript-eslint): enable new no-unsafe-<subject> rules

ackama · Apr 7, 2020 · fb70bb9 · fb70bb9
1 parent 18332b9
commit fb70bb9
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/.eslintplugin/prefer-valid-rules.ts b/.eslintplugin/prefer-valid-rules.ts
@@ -14,7 +14,8 @@ const isNameOfESLintConfigFile = (fname: string): boolean =>
   configFiles.some(name => fname.endsWith(name));
 
 const compileConfigCode = (fileCode: string): ESLint.Linter.Config =>
-  runInNewContext(fileCode, { module: { exports: {} }, require }) ?? {};
+  (runInNewContext(fileCode, { module: { exports: {} }, require }) ??
+    {}) as ESLint.Linter.Config;
 
 const createCLIEngine = (config: ESLint.Linter.Config): ESLint.CLIEngine =>
   new ESLint.CLIEngine({

diff --git a/@typescript-eslint.js b/@typescript-eslint.js
@@ -83,6 +83,9 @@ const config = {
     ],
     '@typescript-eslint/no-unnecessary-qualifier': 'error',
     '@typescript-eslint/no-unnecessary-type-arguments': 'error',
+    '@typescript-eslint/no-unsafe-call': 'error',
+    '@typescript-eslint/no-unsafe-member-access': 'error',
+    '@typescript-eslint/no-unsafe-return': 'error',
     '@typescript-eslint/no-unused-expressions': 'error',
     '@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
     '@typescript-eslint/no-use-before-define': [

diff --git a/test/configs.spec.ts b/test/configs.spec.ts
@@ -16,11 +16,15 @@ const configFiles = fs
   )
   .map(value => value.name);
 
-const requireConfig = (config: string): Required<ESLint.Linter.Config> => ({
+const requireConfig = (
+  config: string
+): ESLint.Linter.Config &
+  Required<Pick<ESLint.Linter.Config, 'plugins' | 'extends' | 'rules'>> => ({
   plugins: [],
   extends: [],
+  rules: {},
   // eslint-disable-next-line global-require,@typescript-eslint/no-require-imports
-  ...require(config)
+  ...(require(config) as Required<ESLint.Linter.Config>)
 });
 
 describe('package.json', () => {
@@ -35,9 +39,7 @@ describe('package.json', () => {
 
 describe('for each config file', () => {
   describe.each(configFiles)('%s config', configFile => {
-    const config: Required<ESLint.Linter.Config> = requireConfig(
-      `./../${configFile}`
-    );
+    const config = requireConfig(`./../${configFile}`);
 
     it('is valid', () => {
       expect.hasAssertions();