Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: specify config dependencies as optional peer dependencies #188

Merged
merged 7 commits into from
Oct 28, 2021
Merged

feat: specify config dependencies as optional peer dependencies #188

merged 7 commits into from
Oct 28, 2021

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Oct 14, 2021

Closes #180

The tests are getting a little hairy but don't expect anymore changes to them in the short-term so will care about that another day; likewise for the duplicated determinePluginPackageName function.

@G-Rath G-Rath added the enhancement New feature or request label Oct 14, 2021
@G-Rath G-Rath requested a review from a team October 14, 2021 22:10
@G-Rath
Copy link
Contributor Author

G-Rath commented Oct 14, 2021 •
edited
Loading

tbh it's probably best to have a test that ensures our peerDependencies ranges match what we've got in devDependencies, but will leave that for another time. I added a test for this, because I was worried about forgetting to update our peer dependencies.

@G-Rath G-Rath force-pushed the handle-optional-peer-dependencies branch 4 times, most recently from 7deb1da to 250fce7 Compare October 16, 2021 01:47
fractalcactus
fractalcactus reviewed Oct 17, 2021
View reviewed changes
test/configs.spec.ts
@@ -12,6 +13,32 @@ const configFiles = fs
)
.map(value => value.name);

/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an interesting type of spec I've never encountered before!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's interesting how different specs can be depending on the code context (e.g. specs for applications, vs for libraries) even when they're using the same testing framework... 🤯

and likewise it can be interested when you realise some of the stuff you can "just do" without actually annoying the underlying testing framework e.g. we can just wrap it calls in an if and Jest is completely fine with that.

@G-Rath G-Rath force-pushed the handle-optional-peer-dependencies branch from 250fce7 to e2bebad Compare October 24, 2021 23:35
@G-Rath G-Rath merged commit a15ab94 into main Oct 28, 2021
@G-Rath G-Rath deleted the handle-optional-peer-dependencies branch October 28, 2021 19:41
github-actions bot pushed a commit that referenced this pull request Oct 28, 2021
@semantic-release-bot
chore(release): 2.3.0 [skip ci]
57e0462 
# [2.3.0](v2.2.1...v2.3.0) (2021-10-28)

### Features

* specify config dependencies as optional peer dependencies ([#188](#188)) ([a15ab94](a15ab94))
@github-actions
Copy link

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fractalcactus fractalcactus fractalcactus approved these changes

@mischa-s mischa-s mischa-s approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure that all plugins used by configs are listed as peer dependencies
3 participants
@G-Rath @fractalcactus @mischa-s