-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a variant which sets up 2FA with devise #77
base: main
Are you sure you want to change the base?
Conversation
The basics are in this now but we need to add:
My goal here is that this should generate everything you need except CSS styling for the feature |
I now think this is big enough to be a whole separate template so I'm going to close this. |
This work has to be paused until devise-two-factor supports Rails 7. I'm trying to help make that happen on devise-two-factor/devise-two-factor#206 |
Edit: this is outdated, latest changes are in this PR now |
copy improvements from another project which doesn't need js and is instead an actual 2-step process with separate pages |
I have copied the files from ackama/rails-template-demo-devise-2fa#11 which incorporates changes made on client projects. This PR is still very WIP. |
Current status
WIP. This branch can be used as inspiration for a devise MFA feature. The design doc included in this PR is particularly useful for understanding the feature.
Background
These changes were initially sketched in ackama/rails-template-demo-devise-2fa#11 and refined in some real client apps. Hat tip to @joshmcarthur who greatly improved my first pass at this. Fixes #61
TODO
TODO
items in the code