Make encode return iterator instead of vec
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build error below occurs:
error[E0207]: the lifetime parameter `'a` is not constrained by the impl trait, self type, or predicates
--> src/encoding/proto.rs:199:6
|
199 | impl<'a, N, A> EncodeMetric for Counter<N, A>
| ^^ unconstrained lifetime parameter
Build error:
error[E0207]: the lifetime parameter `'a` is not constrained by the impl trait, self type, or predicates
--> src/encoding/proto.rs:199:6
|
199 | impl<'a, N, A> EncodeMetric for Counter<N, A>
| ^^ unconstrained lifetime parameter
|
I have compared the allocation count between this branch and the Diffs of source code to check allocation count
The results of allocation count were equal 🤔
$ cargo test --lib encoding::proto::tests::encode_counter_family_with_prefix_with_label --all-features -- --show-output
successes:
---- encoding::proto::tests::encode_counter_family_with_prefix_with_label stdout ----
allocation: 49
$ cargo test --lib encoding::proto::tests::encode_counter_family_with_prefix_with_label --all-features -- --show-output
successes:
---- encoding::proto::tests::encode_counter_family_with_prefix_with_label stdout ----
allocation: 49I think, using |
7 tasks
|
Thanks for experimenting here. I have a patch on top of this patch in the working. Will report back hopefully end of the day @ackintosh. |
|
I played around with this a bit. Thus far I don't have a full solution yet. I think mxinden@2e04787 is a step forward, removing the Still need to give it more thought though. |
src/encoding/proto: Refactor EncodeLabel and EncodeMetric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is based on
protobuf-support. Ref: prometheus#47