Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code polish #392

Merged
merged 2 commits into from
Feb 9, 2025
Merged

code polish #392

merged 2 commits into from
Feb 9, 2025

Conversation

loongs-zhang
Copy link
Member

// Describe your PR here; eg. Fixes #issueNo

Make sure that:

  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed.

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 65.85366% with 14 lines in your changes missing coverage. Please review.

Project coverage is 77.27%. Comparing base (561b7e5) to head (4918ed8).

Files with missing lines Patch % Lines
core/src/net/event_loop.rs 67.56% 12 Missing ⚠️
core/src/co_pool/mod.rs 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
- Coverage   77.31%   77.27%   -0.04%     
==========================================
  Files          45       45              
  Lines        5149     5162      +13     
==========================================
+ Hits         3981     3989       +8     
- Misses       1168     1173       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@loongs-zhang loongs-zhang merged commit 226f326 into acl-dev:master Feb 9, 2025
24 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant