Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix author name and metadata #3391

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Fix author name and metadata #3391

merged 2 commits into from
Jun 13, 2024

Conversation

mathewhuen
Copy link
Contributor

Fix author metadata for 2024.lrec paper (paper ID: 1289) to match the pdf (and existing author ID) and add author name variant to name_variants.yaml (author ID: mathew-huerta-enochian) to catch future cases.

Fix author metadata for 2024.lrec paper (paper ID: 1289) and add author
name variant to name_variants.yaml (author ID: mathew-huerta-enochian)
to catch future cases.
@mathewhuen
Copy link
Contributor Author

The check-build job failed with the following error:

2024-06-12T18:20:37.5050745Z [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
2024-06-12T18:20:37.5051528Z [INFO] Once installed this environment will be reused.
2024-06-12T18:20:37.5052060Z [INFO] This may take a few minutes...
2024-06-12T18:20:37.6127692Z An unexpected error has occurred: CalledProcessError: command: ('/home/runner/work/acl-anthology/acl-anthology/venv/bin/python3', '-mvirtualenv', '/home/runner/.cache/pre-commit/repobjas32pi/py_env-python3')
2024-06-12T18:20:37.6129828Z return code: 1
2024-06-12T18:20:37.6130314Z stdout:
2024-06-12T18:20:37.6131286Z     TypeError: object.__init__() takes exactly one argument (the instance to initialize)
2024-06-12T18:20:37.6132292Z stderr:
2024-06-12T18:20:37.6133029Z     Exception ignored in: <function BaseFileLock.__del__ at 0x7f477f38fbe0>
2024-06-12T18:20:37.6134181Z     Traceback (most recent call last):
2024-06-12T18:20:37.6135484Z       File "/home/runner/work/acl-anthology/acl-anthology/venv/lib/python3.10/site-packages/filelock/_api.py", line 365, in __del__
2024-06-12T18:20:37.6136596Z         self.release(force=True)
2024-06-12T18:20:37.6137904Z       File "/home/runner/work/acl-anthology/acl-anthology/venv/lib/python3.10/site-packages/virtualenv/util/lock.py", line 34, in release
2024-06-12T18:20:37.6138936Z         with self.thread_safe:
2024-06-12T18:20:37.6140124Z     AttributeError: '_CountedFileLock' object has no attribute 'thread_safe'

Is this a problem with the virtual environment? It looks like the latest commit on master also failed a job with the same error.

@mjpost
Copy link
Member

mjpost commented Jun 13, 2024

Looks like a bad filelock. We should be pegging the version numbers, anyway.

@mjpost
Copy link
Member

mjpost commented Jun 13, 2024

It seems filelock is not an explicit dependency of ours. I'm testing a fix on #3357. You could merge in master or push some dummy change which might also work, since they yanked 3.15.0 and pushed up a fix.

Update current changes with recent master changes.
@mathewhuen
Copy link
Contributor Author

Thank you for checking on this. As you suggested, I merged master into my branch and pushed the changes.

@mjpost mjpost merged commit 2ecf153 into acl-org:master Jun 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants