-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ux 431 static testing #34
Changes from all commits
072702f
ad2e41a
771d91a
60c418c
7e3d055
e0759d0
e69128c
73de8a8
ea07b8b
51320f7
434aa0a
e43b3f6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
{ | ||
"env": { | ||
"es6": true, | ||
"browser": true, | ||
"jest": true, | ||
"cypress/globals": true | ||
}, | ||
"extends": ["airbnb", "prettier"], | ||
"parser": "babel-eslint", | ||
"parserOptions": { | ||
"ecmaVersion": 7, | ||
"sourceType": "module", | ||
"ecmaFeatures": { | ||
"jsx": true, | ||
"experimentalObjectRestSpread": true | ||
} | ||
}, | ||
"plugins": ["cypress"], | ||
"rules": { | ||
"camelcase": "off", | ||
"class-methods-use-this": "off", | ||
"consistent-return": "off", | ||
"import/no-extraneous-dependencies": "off", | ||
"import/no-unresolved": "off", | ||
"import/prefer-default-export": "off", | ||
"jsx-a11y/href-no-hash": "off", | ||
"jsx-a11y/label-has-for": "off", | ||
"new-cap": "off", | ||
"no-plusplus": "off", | ||
"no-underscore-dangle": "off", | ||
"prefer-destructuring": "off", | ||
"react/destructuring-assignment": "off", | ||
"react/jsx-filename-extension": [1, { "extensions": [".js"] }], | ||
"react/jsx-one-expression-per-line": "off", | ||
"react/prefer-stateless-function": "off" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
### 🛠 Purpose | ||
|
||
--- | ||
|
||
### ✏️ Notes to Reviewer | ||
|
||
--- | ||
|
||
### 🖥 Screenshots | ||
|
||
--- |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
v10.0.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the Not blocking now. ETA: found it. You can just say There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. executing |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
#Git | ||
.git | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm according to my reading this is indeed necessary, but none of our other modules are ignoring those folders... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think none of our other modules are actually running prettier and using |
||
.github | ||
|
||
#Node modules | ||
node_modules |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
useTabs: false | ||
tabWidth: 2 | ||
printWidth: 120 | ||
trailingComma: es5 | ||
semi: true |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
@import "~tokens/tokens.scss"; | ||
|
||
.story-body { | ||
padding: $space*2; | ||
padding: $space * 2; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cc @mikrotron 😄 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
--install.audit true | ||
--add.audit true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice to restrict jest and cypress to just the files they're relevant for. Can be done later