Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ko 220 #228

Closed
wants to merge 27 commits into from
Closed

Ko 220 #228

wants to merge 27 commits into from

Conversation

kevoconnell
Copy link
Contributor

@kevoconnell kevoconnell commented Nov 5, 2021

Description

  • implemented semantic UI pagination object into users, submissions, and clarifications pages. Calls to get these three items now include a page param.
  • Creating a follow-up issue to track the number of pages needed.

Fixes #220 and #226

Type of change

  • 💡 New feature

How Has This Been Tested?

paginationdemo.mov
  • changed number of items per page to 5 for now.

  • content should update on clicking the pagination object.

  • Tested individually.

Checklist:

  • creates warning for useState number of pages object I have, since the function to check for number of pages isn't created yet!

  • My code follows the style guidelines of this project.

  • I have performed a self-review of my own code.

  • I have commented my code, particularly in hard-to-understand areas.

  • My changes generate no new warnings.

  • My changes do not break any features.

@kevoconnell kevoconnell changed the title Ko 220 (not done yet) Ko 220 Nov 5, 2021
@kevoconnell kevoconnell self-assigned this Nov 5, 2021
@kevoconnell kevoconnell requested a review from Jl5her November 5, 2021 21:00
@kevoconnell
Copy link
Contributor Author

this fix is done here #230

@kevoconnell kevoconnell closed this Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

combining frontend pagination with backend
1 participant