Fixes #54 Mobile Responsiveness Joinus #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tingtingtingtin
requested changes
Nov 28, 2025
Contributor
tingtingtingtin
left a comment
tingtingtingtin
left a comment
There was a problem hiding this comment.
make sure to include a screenshot of changes and include the "ready to review" tag when your PR is ready
src/components/join/JoinUs.tsx
Outdated
Comment on lines
6
to
10
| <div className="min-h-screen"> | ||
| <div className="flex flex-col items-center justify-center pt-20"> | ||
| <Heading title="Join Us" /> | ||
| <p className="text-ascend-dark-blue mt-15 w-2/3 text-center text-2xl"> | ||
| Ascend is a national non-profit organization that is advancing | ||
| Pan-Asian professionals across all industries. We welcome students of | ||
| every major who are passionate about leadership, growth, and | ||
| community. | ||
| </p> | ||
| <div className="shrink-0"> | ||
| <div className="flex flex-col items-center justify-center pt-20 not-visited:flex-col md:flex"> | ||
| <div className="flex w-full max-w-4xl flex-col items-center px-4"> | ||
| <div className="text-center"> |
Contributor
There was a problem hiding this comment.
dont need this many nested divs if each only contains an additional div, you can combine them and their stylings
Collaborator
Author
the branch has been recommited |
tingtingtingtin
requested changes
Dec 4, 2025
Contributor
tingtingtingtin
left a comment
tingtingtingtin
left a comment
There was a problem hiding this comment.
the padding and spacing is quite large on the mobile view, your code doesnt seem to adjust anything for mobile screens
| return ( | ||
| <div className="min-h-screen"> | ||
| <div className="flex flex-col items-center justify-center pt-20"> | ||
| <div className="flex flex-col items-center justify-center pt-20 not-visited:flex-col md:flex"> |
Contributor
There was a problem hiding this comment.
Suggested change
| <div className="flex flex-col items-center justify-center pt-20 not-visited:flex-col md:flex"> | |
| <div className="flex flex-col items-center justify-center pt-20"> |
these dont seem to affect the styling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.