Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abhinav sharma/reccuring logo #52

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

abhnv-shrma
Copy link
Collaborator

Added Recurring Logo but Prettier edited the NotFound.tsx for some reason.

@Kevinloritsch
Copy link
Collaborator

can you include a picture of your issue on the pr? Just kinda a screenshot of what it looks like (not the code, but the rendered version)

Copy link
Collaborator

@mailynnguyen mailynnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a component that uses the logo image and create the white background for it. Let me know if you have any questions.

@mailynnguyen mailynnguyen added the do not merge need some changes label Oct 17, 2024
@abhnv-shrma
Copy link
Collaborator Author

image
Changed to be the logo with a white background.

Copy link
Collaborator

@mailynnguyen mailynnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the styling is good, just make the height and width into percentages.
Make one component, and put the styles into that component, with the logo image.
Then you can call that component in the page.tsx files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge need some changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants