stanley/whyjoin #86
Merged
stanley/whyjoin #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
menthy-wu
suggested changes
Nov 17, 2023
src/components/home/WhyJoin.jsx
Outdated
| <div className="p-16 flex flex-col items-center"> | ||
| <div className="absolute w-1/3 aspect-square bg-ewb-blue-100/40 rounded-full -translate-y-14" /> | ||
| <Title subTitle="GET INVOLVED AND MAKE AN IMPACT!" title="WHY JOIN EWB" /> | ||
| <div className="relative text-center pt-12 ml-72 mr-72 "> |
There was a problem hiding this comment.
instead of margin, try a fraction width like w-9/12
| return ( | ||
| <div className="p-16 flex flex-col items-center"> | ||
| <div className="absolute w-1/3 aspect-square bg-ewb-blue-100/40 rounded-full -translate-y-14" /> | ||
| <Title subTitle="GET INVOLVED AND MAKE AN IMPACT!" title="WHY JOIN EWB" /> |
There was a problem hiding this comment.
go into the title component and add a z-10 to the className, because sometime the title is behind the circle
src/components/home/WhyJoin.jsx
Outdated
| const WhyJoin = () => { | ||
| return <div>WhyJoin</div>; | ||
| return ( | ||
| <div className="p-16 flex flex-col items-center"> |
There was a problem hiding this comment.
if it is just for vertical padding, try py-16 and for the horizontal you can use width to style it so it can be more responsive.
src/components/home/WhyJoin.jsx
Outdated
| activities. We hope that through these activities, students will grow as | ||
| skilled professionals and leaders. | ||
| </div> | ||
| <div className="grid grid-cols-2 gap-4 my-12 mx-72"> |
menthy-wu
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added why join section + small changes to focus.jsx to fix grid content layout
