Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating shadow for mobile on involve page #196

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

ALE00111
Copy link
Collaborator

image

Copy link
Contributor

@seanquiambao seanquiambao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also check the tailwind.config file.

textShadow "sm" is formatted as 0 1px 2px ...(etc etc..)
the first two numbers are the offset shadows.
the second one is the "blurriness" of the shadow (should be set to 0).

src/components/Title.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@seanquiambao seanquiambao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

title shadow should not be blurry. check comment above

@ALE00111
Copy link
Collaborator Author

Oh sorry I didn't understand the first comment fully. I think that's how it should be after changing the config file.

@@ -50,7 +50,7 @@ module.exports = {
blobs1: "url('/assets/blobs1.svg')",
},
textShadow: {
sm: "0 1px 2px var(--tw-shadow-color)",
sm: "0 3px 0px var(--tw-shadow-color)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sm: "0 3px 0px var(--tw-shadow-color)",
sm: "-3px 3px 0px var(--tw-shadow-color)",

@seanquiambao seanquiambao merged commit f3dea09 into dev Aug 23, 2024
5 checks passed
@seanquiambao seanquiambao deleted the ALE00111/shadowMobileResponsive branch August 23, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title Shadow Mobile Responsive
2 participants