Timer Page Implimentation #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahdivyank
reviewed
Jul 25, 2024
shahdivyank
reviewed
Jul 25, 2024
shahdivyank
reviewed
Jul 25, 2024
shahdivyank
reviewed
Jul 25, 2024
shahdivyank
reviewed
Jul 25, 2024
shahdivyank
reviewed
Jul 25, 2024
| @@ -0,0 +1,23 @@ | |||
| const TimerStatus = ({ isComplete, paused }) => { | |||
| if (isComplete) { | |||
There was a problem hiding this comment.
there are already built status components, that should be enough for this?
shahdivyank
reviewed
Jul 26, 2024
shahdivyank
reviewed
Jul 26, 2024
shahdivyank
reviewed
Jul 26, 2024
shahdivyank
reviewed
Jul 26, 2024
shahdivyank
reviewed
Jul 26, 2024
shahdivyank
reviewed
Jul 26, 2024
| setInvalid(true); | ||
| }; | ||
|
|
||
| const numberToDate = (num) => { |
There was a problem hiding this comment.
if num is of type Date, then u dont need to the substr, there are getHours, getMinutes, and getSeconds that you can use
There was a problem hiding this comment.
I tried doing that but apparently we cant separtte the hours minutes and seconds, it all just comes off as one number
shahdivyank
reviewed
Jul 26, 2024
shahdivyank
reviewed
Jul 26, 2024
shahdivyank
reviewed
Jul 26, 2024
shahdivyank
reviewed
Jul 26, 2024
| import Tooltip from "./Tooltip"; | ||
|
|
||
| const TimerControls = ({ | ||
| isEditMode, |
There was a problem hiding this comment.
surely we do not need these many props for each one 😭 is it possible we can reduce this list
shahdivyank
reviewed
Jul 26, 2024
shahdivyank
reviewed
Jul 26, 2024
shahdivyank
reviewed
Jul 26, 2024
shahdivyank
reviewed
Jul 26, 2024
shahdivyank
reviewed
Jul 26, 2024
nidheesh-m-vakharia
force-pushed
the
nidheesh-m-vakharia/timer-page
branch
from
9d81cc1
to
57e35d7
Compare
shahdivyank
reviewed
Jul 29, 2024
| import EditMode from "./EditMode"; | ||
| import { Progress } from "@/components/ui/progress"; | ||
| import { ChevronDown, ChevronUp } from "lucide-react"; | ||
| import { toast } from "react-hot-toast"; |
There was a problem hiding this comment.
should call the custom toaster
shahdivyank
reviewed
Jul 29, 2024
| return; | ||
| } | ||
|
|
||
| if (paused) { |
There was a problem hiding this comment.
combine with upper if check
Closed
…to nidheesh-m-vakharia/timer-page
shahdivyank
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.