-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timer Page Implimentation #1652
Conversation
@@ -0,0 +1,23 @@ | |||
const TimerStatus = ({ isComplete, paused }) => { | |||
if (isComplete) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are already built status components, that should be enough for this?
setInvalid(true); | ||
}; | ||
|
||
const numberToDate = (num) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if num is of type Date, then u dont need to the substr, there are getHours, getMinutes, and getSeconds that you can use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried doing that but apparently we cant separtte the hours minutes and seconds, it all just comes off as one number
import Tooltip from "./Tooltip"; | ||
|
||
const TimerControls = ({ | ||
isEditMode, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
surely we do not need these many props for each one 😭 is it possible we can reduce this list
9d81cc1
to
57e35d7
Compare
import EditMode from "./EditMode"; | ||
import { Progress } from "@/components/ui/progress"; | ||
import { ChevronDown, ChevronUp } from "lucide-react"; | ||
import { toast } from "react-hot-toast"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should call the custom toaster
return; | ||
} | ||
|
||
if (paused) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
combine with upper if check
…to nidheesh-m-vakharia/timer-page
No description provided.