AgentEinstein/add error checking #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AgentEinstein
commented
Nov 5, 2023
AgentEinstein
commented
…to AgentEinstein/SuccessfullyUpdated
…to AgentEinstein/AddErrorChecking
Closed
shahdivyank
reviewed
Nov 5, 2023
src/components/dynamic/user/Team.jsx
Outdated
| @@ -37,6 +37,10 @@ const Team = ({ user, setUser }) => { | |||
| }; | |||
|
|
|||
| const handleJoin = () => { | |||
| if (id.team.length === 0) { | |||
There was a problem hiding this comment.
u can just check for an empty string instead of character comparison
shahdivyank
reviewed
Nov 5, 2023
src/components/dynamic/user/Team.jsx
Outdated
| @@ -37,6 +37,10 @@ const Team = ({ user, setUser }) => { | |||
| }; | |||
|
|
|||
| const handleJoin = () => { | |||
| if (id.team == null) { | |||
There was a problem hiding this comment.
triple equals and it should just be checking for empty string and not null
There was a problem hiding this comment.
That doesn't seem to work. Instead, this jumps to the very last else statement on line 55.
There was a problem hiding this comment.
On the other hand, !id.team seems to work, did you prefer that implementation instead?
There was a problem hiding this comment.
what are the initial values for the id.team?
There was a problem hiding this comment.
it's probably empty
There was a problem hiding this comment.
check the values and do a type check for it instead of a general null check
shahdivyank
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.