Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to acmeair-nodejs #20

Open
wants to merge 79 commits into
base: master
Choose a base branch
from
Open

Update to acmeair-nodejs #20

wants to merge 79 commits into from

Conversation

robbdempsey
Copy link

Quite a bit happening in this PR.

  • Use Fastify
  • Use Promises / async/await where possible
  • Use Pino for logging
  • Update dependencies
  • Identify and Improve performance bottlenecks (autocanon scripts included)

cc: @jasnell

jackdclark and others added 30 commits January 31, 2018 17:07
@jackdclark
initial move of routes to fastify
d468c5a
@jackdclark
stream reply in hystrix
b77a243
@jackdclark
finish initial move to fastify, remove express module
ce29e01
@jackdclark
fastify request schema validation
e923a8c
work-in-progress app moved to fastify-cli/fastify-plugin architecture
c0babb5
@robbdempsey
[dojo] update to 1.13.0
99475be
@robbdempsey
[loader-data] removing old reference
f0e38ae
@robbdempsey
[settings]
794f03c 
moving all settings to the same file
@robbdempsey
[mongo] new module for interacting with mongodb
560b531
@robbdempsey
[loader] new version
c08845b
@robbdempsey
[plugins] moving config and env to their module
170e249
@robbdempsey
[routes] splits the routes out
d83fc43
@robbdempsey
[services] splits out work to be done
e9841ed
@robbdempsey
[config] updated to work with api changes
b92346d
@robbdempsey
[config] bump version of dojo
d40dccd
@robbdempsey
[loader] update for api and bump dojo
48cb561
@robbdempsey
[common] update login + logout
a7a1d10
@robbdempsey
[acmeair-common] fix misspelling
c535c39
@robbdempsey
[customer-profile] update for api
a4399d5
@robbdempsey
[flights] updates for api
5cd16d1
@robbdempsey
[check-in] updates for api
f4e0cb1
@robbdempsey
[app]
0f78744 
changes based on breaking everything out into various routes and services
@robbdempsey
[package] tidy up
4f9e5d1
@robbdempsey
[clean-up] remove previous work
c2bb964
@robbdempsey
[routes] moved to src/routes
da24fbb
@robbdempsey
[loader] moved to src/loader
5dc35f5
@robbdempsey
[gitignore] update for more recent configs
274d54b
@robbdempsey
[happy-lint]
968ebda
@robbdempsey
[node] sets engine to 8.11.3
82f3744
@robbdempsey
[determine-env]
181d9be 
move db settings to env and enable dotenv in fastify-env
still need to determine if the VCAP items are required
@robbdempsey
[tidy-up]
feaee90
@robbdempsey
[standard] remove unneccessary ignore path
8d26c98
@robbdempsey
[package] removing unnecessary dependency
ad262a5
@robbdempsey
[ignore] /data
e3ac8a7
@robbdempsey
[logging] add connection details for mongo
e069813
@robbdempsey
[docker] udpate usage for mongo
9824022
@robbdempsey
Merge pull request #4 from nearform/robb-fastify
ba149cd 
[fastify + async/await]

focused on getting the backend to a more modern place so that we can run benchmarks
@robbdempsey
[perf] adds autocannon and clinic to dev dependencies
4e27a0b
@robbdempsey
[WIP] old v new
6c26e2f 
autocannon tests that will run against the flights routes of the old and new code
@robbdempsey
[mongodb] add poolSize to connection
f9ce996
@robbdempsey
[app]
f060bc0 
switches up the way we run the app. clinic flame was having
issues with fastify-cli not providing enough context.

doctor and flame both work with this version
@robbdempsey
[clean-up] old autocannon results
e9f2d7e
@robbdempsey
[package] update dependencies and add scripts
1ed2f13
@robbdempsey
[test] 10 connections, 30s duration
7b45f42
@robbdempsey
[clean-up] unused files
3c4ebe4
@robbdempsey
[happy-lint]
d8e195e
@robbdempsey
[benchmarks]
1071d40 
moving autocannon scripts to benchmarks
@robbdempsey
[benchmarks] adds autocannon.track
964fb86
@robbdempsey
Merge pull request #5 from nearform/perf
5428237 
[performance]
@robbdempsey
[benchmark-old] making duration same as perf-flights
fa399f7
@robbdempsey
[mongo] adds ability to create indices
c78ff00
@robbdempsey
[db] adds ability to create indices
3993521
@robbdempsey
[loader] adds ability to create indices
7258c24
@robbdempsey
[flights]
4ee52a9 
change the way we query so the benchmark is inline with the previous version
@robbdempsey
Merge pull request #6 from nearform/benchmark-comparison
0235b72 
[benchmark]
@robbdempsey
[lru] adds dependency
ac9dad3
@robbdempsey
[flights] adds caching for segments and flights
c224dc1
@robbdempsey
[cache] move to plugin
0ea4cb6
@robbdempsey
Merge pull request #7 from nearform/with-lru
41d67e3 
[caching]
@robbdempsey robbdempsey mentioned this pull request Aug 20, 2018
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robbdempsey @jackdclark