Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw a white background on the graph #40

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

NoahBres
Copy link
Contributor

@NoahBres NoahBres commented Jan 3, 2021

With the pause feature, it's very convenient to grab samples of the graph. As the graph is a canvas, one can right click and choose copy/save image to download directly from the canvas. Previously, the graph never drew a background. It would result in an image with a transparent background:

Screen Shot 2021-01-03 at 5 38 47 PM

Drawing a white rectangle solves this issue:

Screen Shot 2021-01-03 at 5 39 16 PM

@rbrott rbrott merged commit 3cdcee6 into acmerobotics:master Jan 4, 2021
@NoahBres NoahBres deleted the white-graph-bg branch January 4, 2021 01:47
j5155 pushed a commit to jdhs-ftc/ftc-dashboard-record that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants