Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix windows compile error #46

Merged
merged 1 commit into from
Feb 1, 2021
Merged

fix windows compile error #46

merged 1 commit into from
Feb 1, 2021

Conversation

smartynenko
Copy link
Contributor

Current configuration is not compliable on Windows with default AS/git settings because of different new line format. Pls update lint settings to enable automated handing of cr/lf characters

> Task :FtcDashboard:yarn_build
yarn run v1.22.10
$ craco build
Creating an optimized production build...
Failed to compile.

src\components\AutoFitCanvas.jsx
  Line 1:27:   Delete `�??`  prettier/prettier
  ...

@rbrott rbrott merged commit 028044c into acmerobotics:master Feb 1, 2021
@smartynenko smartynenko deleted the fix-prettier-compilation-on-windows branch February 2, 2021 00:49
j5155 pushed a commit to jdhs-ftc/ftc-dashboard-record that referenced this pull request Jul 22, 2024
@smartynenko
Relax prettier config to allow consistent use of CRLF (acmerobotics#46)
dd9c106 
Co-authored-by: Sergei Martynenko <sergei.martynenko@gm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smartynenko @rbrott