-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump deps #92
Bump deps #92
Conversation
State being overwritten rather than appended to in this.setState() calls
Verified on running opmode ✅ |
"Bump deps" definitely undersold this. Thanks for some much-needed maintenance!
I use them 😄 Can you elaborate on the development friction? Does it just encourage fewer, bigger commits? I'd generally rather handle formatting this way than set up GH actions or something.
I didn't even catch it on my second review. Silly |
This is entirely irrelevant but regarding previous work in a professional setting, they just proved to be an annoyance as the hooks are generally very slow and you were discouraged from making frequent commits. Commits failing for linting errors felt incredibly unnecessary since you were not really concerned until merging into the main branch. I've had similar discussions with other teams. |
* Bump deps * Remove redux types * Remove CRA relic * Create index.d.ts and add svgr types * Fix type errors and state overwriting in OpModeView State being overwritten rather than appended to in this.setState() calls * Replace node's process env with vite's https://vitejs.dev/guide/env-and-mode.html#modes * Switch from mode string to DEV boolean * Ignore socketMiddleware type errors * Switch to Tailwind 3 colored shadows * Bump dep * Remove package-lock.json * React 18 createRoot * Bump gradle node version to latest LTS * Remove redundant React import * New yarn.lock * Reinstate pre-commit hooks
Significant package changes:
12.13.0
->18.12.1
18.12.1
is the latest LTS versionvite
: 2 -> 3@vitejs/plugin-react-refresh
uninstalled, replaced by@vitejs/plugin-react
ESNext
ES5
option deprecatedreact-scripts
package removed. Relic fromcreate-react-app
react
: 17 -> 18redux
: 4.0 -> 4.2createStore
deprecated with recommendation to move to@reduxjs/toolkit
. Details in changelog. No changes to Dash required but deprecation will halt further upgradesreact-redux
: 7 -> 8redux-thunk
: 2.3 -> 2.4tailwindcss
: 2 -> 3@tailwindcss/jit
packagetailwind.config.js
. Removed.Misc
npm run dev
, equivalent to currentnpm run start
npm run dev
seems to have overtakennpm run start
as the standard in terms of default ecosystem documentation assumptions. Just a small convenience changeOpModeView
(introduced in Address getGamepads changes #72)socketMiddleware.ts
createRoot