Tele op action #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… StickyGamepad is now updated within the Robot
… selection of autos
kellyrm
commented
Dec 2, 2020
There was a problem hiding this comment.
A few things to consider:
You can't have multiple teleops with different button mappings if subsystems capture button input themselves.
Button mappings will also be spread out between multiple files, which may be desired, but also could make it easier to accidentally map one button to multiple actions.
| import com.acmerobotics.robomatic.util.StickyGamepad; | ||
| import com.qualcomm.robotcore.hardware.Gamepad; | ||
|
|
||
| public interface TeleOpActionImpl { |
There was a problem hiding this comment.
Impl is short for Implementation, this is an interface
There was a problem hiding this comment.
If you had some abstract interface and then a default implementation of that interface, you would call the implementation interfacenameImpl
|
I noticed the commit adding the field image, go ahead and merge if you want @jbeta02. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.