Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add online.net DNS API #2095

Merged
merged 8 commits into from
Feb 15, 2019
Merged

Add online.net DNS API #2095

merged 8 commits into from
Feb 15, 2019

Conversation

Augustin-FL
Copy link
Contributor

This Pull Request add support for the Online (https://online.net/) DNS API.

Related issue : #2093

@Neilpang
Copy link
Member

please confirm whether you have checked EVERY item in this guide : https://github.com/Neilpang/acme.sh/wiki/DNS-API-Dev-Guide

Thanks.

@Augustin-FL
Copy link
Contributor Author

@Neilpang yes, I have checked every item in this guide.

  1. use cloudflare as reference : yes. OVH has also been used as reference
  2. script name having the correct name: yes
  3. location in dnsapi/ : yes
  4. shebang : use sh from env, not something else : yes
  5. has dns_myapi_<add|rm> functions: yes
  6. add function guides:
    6.1. gets fulldomain/txtvalue in dns_myapi_add(): yes
    6.2. save credentials in _add() : yes, via _online_check_config()
    6.3. detect root zone: yes, via _get_root(). I have tested
    example.org
    subdomain.example.org
    subsubdomain.subdomain.example.org
    domainthatidontown.org
    invaliddomain
    6.4. use _post/ _get, not wget / curl : yes, in _online_rest() function.
    6.5 process strings using provided functions and some basic commands (cut,...), not awk: yes.
  7. rm function runs standalone: yes, records are correctly removed.
  8. support wildcard txt certs: yes, tested with *.example.org
  9. updated docs accordingly : yes
  10. creating issue related to this DNS provider : yes

dnsapi/dns_online.sh Outdated Show resolved Hide resolved
dnsapi/dns_online.sh Outdated Show resolved Hide resolved
dnsapi/dns_online.sh Outdated Show resolved Hide resolved
@Neilpang
Copy link
Member

Please confirm this is ready to merge, and this is still working as expected.

Thanks.

@Augustin-FL
Copy link
Contributor Author

I confirm that it is still working as expected (I performed tests again to make sure)

@Neilpang this PR is ready to be merged !

@Neilpang Neilpang merged commit 4ade446 into acmesh-official:dev Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants