Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to work with one.com #2276

Merged
merged 7 commits into from
Jun 4, 2019
Merged

updated to work with one.com #2276

merged 7 commits into from
Jun 4, 2019

Conversation

der-berni
Copy link
Contributor

rev command not found on OpenWrt
CURL does not work, using wget
JSESSIONID replaced with OneSIDCrmAdmin
CSRF_G_TOKEN not needed

rev command not found on OpenWrt
CURL does not work, using wget
JSESSIONID replaced with OneSIDCrmAdmin
CSRF_G_TOKEN not needed
#
# export ONECOM_User="username"
# export ONECOM_Password="password"
# export ONECOM_USER="username"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not change the name from ONECOM_User to ONECOM_USER.
The existing users will kill you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my fault. I misread.
#2098 (comment)

See my second commit.

Revert ONECOM_PASSWORD back to ONECOM_Password
and ONECOM_USER back to ONECOM_User

#CURL does not work
local tmp_USE_WGET=$ACME_USE_WGET
ACME_USE_WGET=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, never select to use wget or curl in your script.
It's control by acme.sh

if curl does not work, you can display an _err message to ask the user to use wget wih --use-wget

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't understand why curl is not working ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the response from curl is every time the login page.
the same results on other devices.
i will try to get more info

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the follow redirects (Option) "-L" it works with curl

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i fixed to work with curl

Now works with curl.
Check the root domain.
@Neilpang
Copy link
Member

fix the CI errors first.

@Neilpang
Copy link
Member

Neilpang commented Jun 2, 2019

@Neilpang Neilpang merged commit 6650072 into acmesh-official:dev Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants