Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aurora DNS API #3460

Merged
merged 1 commit into from
Apr 17, 2021
Merged

Add Aurora DNS API #3460

merged 1 commit into from
Apr 17, 2021

Conversation

JaZo
Copy link
Contributor

@JaZo JaZo commented Mar 27, 2021

This PR adds support for the Aurora DNS API offered by the Dutch cloud provider PCextreme B.V.

Documentation: https://github.com/acmesh-official/acme.sh/wiki/dnsapi#131-using-the-aurora-api
Issue: #3459
Latest actions run: https://github.com/JaZo/acme.sh/actions/runs/753125822

dnsapi/dns_aurora.sh Outdated Show resolved Hide resolved
@Neilpang
Copy link
Member

BTW, please fix your CI checks:
https://github.com/JaZo/acme.sh/actions/runs/692884497

It's not passing.

@JaZo
Copy link
Contributor Author

JaZo commented Mar 29, 2021

@Neilpang I've re-ran the action several times, but every time it fails at a different point. The logs also don't give me a clue of what went wrong. One time it got through and even reached the FreeBSD job and then it failed on some SSH and Rsync issues. Do you have a direction I should look? Those issues don't seem to be related to my new API implementation, but maybe I'm overlooking something?

@Neilpang
Copy link
Member

please set a larger TEST_DNS_SLEEP value.

https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test

@JaZo
Copy link
Contributor Author

JaZo commented Apr 16, 2021

@Neilpang My implementation had some issues on OS X, but I managed to fix those. Build is successfull now, so it's ready for review!

N.B. shfmt job is failing, but that's caused by a different DNS API.

@Neilpang Neilpang merged commit c576af7 into acmesh-official:dev Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants