Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMTP notify: Use grep -E instead of expr #4528

Merged
merged 1 commit into from
Mar 1, 2023
Merged

SMTP notify: Use grep -E instead of expr #4528

merged 1 commit into from
Mar 1, 2023

Conversation

chris03
Copy link
Contributor

@chris03 chris03 commented Mar 1, 2023

expr was printing expr: warning: '^.*[<>"]': using '^' as the first character of a basic regular expression is not portable;

To reproduce the issue:

docker run --rm -e SMTP_FROM=alain@example.com alpine:latest sh -c 'apk add curl openssl && curl https://get.acme.sh/ | sh -s email=bob@example.com && /root/.acme.sh/acme.sh --set-notify --notify-hook smtp'

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Welcome
Please make sure you're read our Code-of-conduct and add the usage here: notify.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨

@Neilpang
Copy link
Member

Neilpang commented Mar 1, 2023

fix the shellcheck errors

@chris03 chris03 changed the title Use egrep instead of expr SMTP notify: Use grep -E instead of expr Mar 1, 2023
expr was printing  `expr: warning: '^.*[<>"]': using '^' as the first character of a basic regular expression is not portable;`
@Neilpang Neilpang merged commit 0ea84ad into acmesh-official:dev Mar 1, 2023
@chris03 chris03 deleted the bugfix/replace-expr branch March 1, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants