Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to handle LE overload status 503 appropriately #4531

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Fix to handle LE overload status 503 appropriately #4531

merged 2 commits into from
Mar 2, 2023

Conversation

mhoffrog
Copy link
Contributor

@mhoffrog mhoffrog commented Mar 1, 2023

This will fix #4530

As you can see in the test result - it now retries after code='503' with sleeping for 3 seconds and the retried request succeeds with '200'!

Test result:

[Wed Mar  1 23:06:28 UTC 2023] The txt record is added: Success.
[Wed Mar  1 23:06:28 UTC 2023] Sleep 720 seconds for the txt records to take effect
[Wed Mar  1 23:18:28 UTC 2023] ok, let's start to verify
[Wed Mar  1 23:18:28 UTC 2023] Verifying: my-domain.de
[Wed Mar  1 23:18:28 UTC 2023] d='my-domain.de'
[Wed Mar  1 23:18:28 UTC 2023] keyauthorization='MimrCMJjMxiol_rwo_QLHF7axEiipglpFfRkDgXTJGc.ntir6iq6WAnRCXiaD6cID71vGHVv4q6gfeZWZ1mTt1U'
[Wed Mar  1 23:18:28 UTC 2023] uri='https://acme-staging-v02.api.letsencrypt.org/acme/chall-v3/5566577513/tbwcow'
[Wed Mar  1 23:18:28 UTC 2023] _currentRoot='dns_netcup'
[Wed Mar  1 23:18:28 UTC 2023] url='https://acme-staging-v02.api.letsencrypt.org/acme/chall-v3/5566577513/tbwcow'
[Wed Mar  1 23:18:28 UTC 2023] payload='{}'
[Wed Mar  1 23:18:28 UTC 2023] POST
[Wed Mar  1 23:18:28 UTC 2023] _post_url='https://acme-staging-v02.api.letsencrypt.org/acme/chall-v3/5566577513/tbwcow'
[Wed Mar  1 23:18:28 UTC 2023] _CURL='curl --silent --dump-header /home/runner/work/nc_wildcerts/nc_wildcerts/acme.sh/config/http.header  -L  -g '
[Wed Mar  1 23:18:28 UTC 2023] _ret='0'
[Wed Mar  1 23:18:28 UTC 2023] code='200'
[Wed Mar  1 23:18:28 UTC 2023] trigger validation code: 200
[Wed Mar  1 23:18:28 UTC 2023] Pending, The CA is processing your order, please just wait. (1/30)
[Wed Mar  1 23:18:28 UTC 2023] sleep 2 secs to verify again
[Wed Mar  1 23:18:30 UTC 2023] checking
[Wed Mar  1 23:18:30 UTC 2023] url='https://acme-staging-v02.api.letsencrypt.org/acme/chall-v3/5566577513/tbwcow'
[Wed Mar  1 23:18:30 UTC 2023] payload
[Wed Mar  1 23:18:30 UTC 2023] POST
[Wed Mar  1 23:18:30 UTC 2023] _post_url='https://acme-staging-v02.api.letsencrypt.org/acme/chall-v3/5566577513/tbwcow'
[Wed Mar  1 23:18:30 UTC 2023] _CURL='curl --silent --dump-header /home/runner/work/nc_wildcerts/nc_wildcerts/acme.sh/config/http.header  -L  -g '
[Wed Mar  1 23:18:30 UTC 2023] _ret='0'
[Wed Mar  1 23:18:30 UTC 2023] code='200'
[Wed Mar  1 23:18:30 UTC 2023] Success
[Wed Mar  1 23:18:30 UTC 2023] pid
[Wed Mar  1 23:18:30 UTC 2023] Skip for removelevel:
[Wed Mar  1 23:18:30 UTC 2023] Verifying: *.my-domain.de
[Wed Mar  1 23:18:30 UTC 2023] d='*.my-domain.de'
[Wed Mar  1 23:18:30 UTC 2023] keyauthorization='5hmWMWoML_wELVYA29TD1AwpX8q0PDJZqQO576PVTqs.ntir6iq6WAnRCXiaD6cID71vGHVv4q6gfeZWZ1mTt1U'
[Wed Mar  1 23:18:30 UTC 2023] uri='https://acme-staging-v02.api.letsencrypt.org/acme/chall-v3/5566577503/WB59dg'
[Wed Mar  1 23:18:30 UTC 2023] _currentRoot='dns_netcup'
[Wed Mar  1 23:18:30 UTC 2023] url='https://acme-staging-v02.api.letsencrypt.org/acme/chall-v3/5566577503/WB59dg'
[Wed Mar  1 23:18:30 UTC 2023] payload='{}'
[Wed Mar  1 23:18:31 UTC 2023] POST
[Wed Mar  1 23:18:31 UTC 2023] _post_url='https://acme-staging-v02.api.letsencrypt.org/acme/chall-v3/5566577503/WB59dg'
[Wed Mar  1 23:18:31 UTC 2023] _CURL='curl --silent --dump-header /home/runner/work/nc_wildcerts/nc_wildcerts/acme.sh/config/http.header  -L  -g '
[Wed Mar  1 23:18:31 UTC 2023] _ret='0'
[Wed Mar  1 23:18:31 UTC 2023] code='200'
[Wed Mar  1 23:18:31 UTC 2023] trigger validation code: 200
[Wed Mar  1 23:18:31 UTC 2023] Pending, The CA is processing your order, please just wait. (1/30)
[Wed Mar  1 23:18:31 UTC 2023] sleep 2 secs to verify again
[Wed Mar  1 23:18:33 UTC 2023] checking
[Wed Mar  1 23:18:33 UTC 2023] url='https://acme-staging-v02.api.letsencrypt.org/acme/chall-v3/5566577503/WB59dg'
[Wed Mar  1 23:18:33 UTC 2023] payload
[Wed Mar  1 23:18:33 UTC 2023] POST
[Wed Mar  1 23:18:33 UTC 2023] _post_url='https://acme-staging-v02.api.letsencrypt.org/acme/chall-v3/5566577503/WB59dg'
[Wed Mar  1 23:18:33 UTC 2023] _CURL='curl --silent --dump-header /home/runner/work/nc_wildcerts/nc_wildcerts/acme.sh/config/http.header  -L  -g '
[Wed Mar  1 23:18:33 UTC 2023] _ret='0'
[Wed Mar  1 23:18:33 UTC 2023] code='503'
[Wed Mar  1 23:18:33 UTC 2023] It seems the CA server is overloaded now, let's wait and retry. Sleeping 3 seconds.
[Wed Mar  1 23:18:36 UTC 2023] HEAD
[Wed Mar  1 23:18:36 UTC 2023] _post_url='https://acme-staging-v02.api.letsencrypt.org/acme/new-nonce'
[Wed Mar  1 23:18:36 UTC 2023] _CURL='curl --silent --dump-header /home/runner/work/nc_wildcerts/nc_wildcerts/acme.sh/config/http.header  -L  -g  -I  '
[Wed Mar  1 23:18:36 UTC 2023] _ret='0'
[Wed Mar  1 23:18:36 UTC 2023] POST
[Wed Mar  1 23:18:36 UTC 2023] _post_url='https://acme-staging-v02.api.letsencrypt.org/acme/chall-v3/5566577503/WB59dg'
[Wed Mar  1 23:18:36 UTC 2023] _CURL='curl --silent --dump-header /home/runner/work/nc_wildcerts/nc_wildcerts/acme.sh/config/http.header  -L  -g '
[Wed Mar  1 23:18:36 UTC 2023] _ret='0'
[Wed Mar  1 23:18:36 UTC 2023] code='200'
[Wed Mar  1 23:18:37 UTC 2023] Success
[Wed Mar  1 23:18:37 UTC 2023] pid
[Wed Mar  1 23:18:37 UTC 2023] Skip for removelevel:
[Wed Mar  1 23:18:37 UTC 2023] pid
[Wed Mar  1 23:18:37 UTC 2023] No need to restore nginx, skip.
[Wed Mar  1 23:18:37 UTC 2023] _clearupdns
[Wed Mar  1 23:18:37 UTC 2023] dns_entries='my-domain.de,_acme-challenge.my-domain.de,,dns_netcup,zsbrpdFXXDXxbKTr6Bks6RwqLu32OtucQbIsx6dSFfs,/home/runner/work/nc_wildcerts/nc_wildcerts/acme.sh/dnsapi/dns_netcup.sh
my-domain.de,_acme-challenge.my-domain.de,,dns_netcup,0boCVr-bnKUZJsjCzh-Rt1XpcmJWLQwiymwBD2BuYWg,/home/runner/work/nc_wildcerts/nc_wildcerts/acme.sh/dnsapi/dns_netcup.sh'
[Wed Mar  1 23:18:37 UTC 2023] Removing DNS records.

@mhoffrog mhoffrog changed the title Bugfix/issue 4530 fix http status 503 Fix to handle LE overload status 503 appropriately Mar 2, 2023
@mhoffrog mhoffrog mentioned this pull request Mar 2, 2023
Closed
@Neilpang Neilpang merged commit 67f5433 into acmesh-official:dev Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhoffrog @Neilpang