Fix Variomedia API #4787
Merged
Fix Variomedia API #4787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome |
DNS API Test for Variomedia successfully completed. |
Neilpang
reviewed
Sep 13, 2023
dnsapi/dns_variomedia.sh
Outdated
| fulldomain=$1 | ||
| i=1 | ||
| domain=$1 | ||
| i=2 |
There was a problem hiding this comment.
i should start from "1"
There is no "_acme-challenge" prefix if it's working in dns alias mode.
There was a problem hiding this comment.
Ok I changed that, Github actions tests successfully completed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Variomedia API integration is broken for quite some time now. There are 3 problems that have to be addressed:
The determination of the root domain does not work porperly
This has been addressed in the following pull request that never got merged: Improved determination of root domain for the Variomedia DNS API #3244
The deletion of _acme-challenge DNS records fails if their content starts with
-This is due to grep interpreting all strings starting with
-as options. In order to fix this, the option--has to be added before the search term"$txtvalue"in grep (Improved determination of root domain for the Variomedia DNS API #3244 (comment)).The deletion of _acme-challenge DNS records fails due to a recent change in the API
The API returns a new field
tagsin theattributesobject since June 7 with a (usually empty) list of tags (e.g."tags":[]or"tags":["custom","dyndns"]).This adds more
[characters to the return string from the API, which break the inital split of the returned JSON data using cut (cut -d '[' -f2). The easiest solution that I could come up with is to delete the tags field entirely using sed (sed -E 's/,"tags":\[[^]]*\]//g').I have made the necessary changes to fix all these problems and done some testing to confirm that the Variomedia API works again.
Note: This is a second pull request, I closed the first one (#4769) because I screwed up the testing.