Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dnsapi script for OpenProvider switched current API specifications #6111

Closed
wants to merge 5 commits into from

Conversation

Lambiek12
Copy link

Updated the dnsapi script for OpenProvider to use their current REST APIs.

Main new feature it now allows the add/removal of single DNS record entry in a zone instead of having to-do a full zone overlay with all records when trying to add/remove a single entry.

Documentation for reference available at docs.openprovider.com.

Note;
Will have to update the documentation once approved, due to breaking change in API authentication. The hashed password isn't supported anymore by OpenProvider with the current (REST) API.

@Lambiek12
Copy link
Author

Welcome First thing: don't send PR to the master branch, please send to the dev branch instead. Please make sure you've read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. We look forward to reviewing your Pull request shortly ✨ 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

Hopefully the DNS-API-Test is done correctly 🤞

Not very familiar with Github actions still using Azure DevOps on day-to-day tasks.

@acmesh-official acmesh-official deleted a comment from github-actions bot Nov 23, 2024
@Neilpang
Copy link
Member

Is the old api still working ?

@Lambiek12
Copy link
Author

Yes the old API is still online and the issue i run into early in the year where the script wasn't working, but this was fixed in the current master version this summer. Although i already started at the time to replace it with the newer REST API, finally decided to just do the PR to satisfy the request in #2104 thread to switch.

@Neilpang
Copy link
Member

if the old api is still working, we MUST keep it compatible. otherwise the existing users would panic.
You can make a new one, eg: dns_openprovider_rest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants