fix yml

acocalypso · Oct 5, 2023 · 27f812c · 27f812c
1 parent 3fe7246
commit 27f812c
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 15 deletions.
diff --git a/.github/workflows/android-ci.yml b/.github/workflows/android-ci.yml
@@ -68,18 +68,21 @@ jobs:
         run: echo $KEYSTORE_FILE | base64 -d > /home/runner/work/reactmap-android/reactmap-android/keystore.jks
 
       - name: Build apk release project (APK) - ${{ env.main_project_module }} module
-        run: ./gradlew assembleRelease
-          -PKEYSTORE_FILE="/home/runner/work/reactmap-android/reactmap-android/keystore.jks"
-          -PKEYSTORE_PASSWORD=${{ secrets.KEYSTORE_PASSWORD }}
-          -PSIGNING_KEY_ALIAS=${{ secrets.KEY_ALIAS }}
-          -PSIGNING_KEY_PASSWORD=${{ secrets.KEY_PASSWORD }}
+        run: ./gradlew assembleRelease -x test
+        env:
+          SIGNING_KEY_ALIAS: ${{ secrets.KEY_ALIAS }}
+          SIGNING_KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}
+          SIGNING_STORE_PASSWORD: ${{ secrets.KEYSTORE_PASSWORD }}
+        #  -PKEYSTORE_FILE="/home/runner/work/reactmap-android/reactmap-android/keystore.jks"
+        #  -PKEYSTORE_PASSWORD=${{ secrets.KEYSTORE_PASSWORD }}
+        #  -PSIGNING_KEY_ALIAS=${{ secrets.KEY_ALIAS }}
+        #  -PSIGNING_KEY_PASSWORD=${{ secrets.KEY_PASSWORD }}
 
       - name: Upload Artifact
         uses: actions/upload-artifact@v3
         with:
           name: Reactmap-android
-          #path: ${{ env.main_project_module }}/build/outputs/apk/release/
-          path: ${{ env.main_project_module }}/release/
+          path: ${{ env.main_project_module }}/build/outputs/apk/release/
   release:
    name: Release APK
    needs: build

diff --git a/app/build.gradle.kts b/app/build.gradle.kts
@@ -32,26 +32,26 @@ android {
         } else "null")
     }
 
-    /*signingConfigs {
+    signingConfigs {
         create("release") {
-            storeFile = file(project.property("KEYSTORE_FILE").toString())
-            storePassword = project.property("KEYSTORE_PASSWORD").toString()
-            keyAlias = project.property("SIGNING_KEY_ALIAS").toString()
-            keyPassword = project.property("SIGNING_KEY_PASSWORD").toString()
+            storeFile = file("../keystore.jks")
+            storePassword = System.getenv("KEYSTORE_PASSWORD")
+            keyAlias = System.getenv("SIGNING_KEY_ALIAS")
+            keyPassword = System.getenv("SIGNING_KEY_PASSWORD")
         }
-    }*/
+    }
 
     buildTypes {
         debug {
             isPseudoLocalesEnabled = true
         }
-        release {
+        getByName("release") {
             isMinifyEnabled = true
             proguardFiles(getDefaultProguardFile("proguard-android-optimize.txt"), "proguard-rules.pro")
             if (!pluginManager.hasPlugin("com.google.gms.google-services")) {
                 the<CrashlyticsExtension>().mappingFileUploadEnabled = false
             }
-            // signingConfig = signingConfigs.getByName(name)
+            signingConfig = signingConfigs.getByName("release")
         }
     }
     buildFeatures.buildConfig = true