Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Reinstall prompts for LE TOS and email #790

Closed
ibuildthecloud opened this issue Oct 19, 2022 · 2 comments
Closed

Reinstall prompts for LE TOS and email #790

ibuildthecloud opened this issue Oct 19, 2022 · 2 comments
Assignees
@cjellick
Labels
good first issue Good for newcomers kind/bug Something isn't working
Milestone
v0.4.1

Comments

@ibuildthecloud
Copy link
Member

If you run install a second time with --lets-encrypt=enabled and previously had entered the email/tos it will reprompt.

I think in this situation it should use the previous values to be consistent to the rest of the install args. In general if you run install --foo=true and then install again with no args, --foo=true should persist.
@cjellick cjellick added this to the Backlog milestone Oct 31, 2022
@tylerslaton tylerslaton self-assigned this Oct 31, 2022
@cjellick cjellick modified the milestones: Backlog, v0.4.0 Oct 31, 2022
tylerslaton added a commit to tylerslaton/runtime that referenced this issue Nov 2, 2022
@tylerslaton
Merge client side and server side configs when installing (acorn-io#790)
8ae67af 
Signed-off-by: tylerslaton <mtslaton1@gmail.com>
@tylerslaton tylerslaton mentioned this issue Nov 2, 2022
Merged
cjellick added a commit that referenced this issue Nov 16, 2022
@cjellick
Merge pull request #834 from tylerslaton/consistent-prompts
64b280a 
Merge client side and server side configs when installing (#790)
cjellick added a commit that referenced this issue Nov 16, 2022
@cjellick
Revert "Merge client side and server side configs when installing (#790…
12cdfef 
…)"
@cjellick cjellick reopened this Nov 16, 2022
@cjellick
Copy link
Member

See: obot-platform/obot#883

reopening

cjellick added a commit to cjellick/acorn that referenced this issue Nov 16, 2022
@cjellick
Revert "Merge client side and server side configs when installing (ac…
a9bc30c 
…orn-io#790)"

This reverts commit 8ae67af.
@cjellick cjellick mentioned this issue Nov 16, 2022
Merged
cjellick added a commit to cjellick/acorn that referenced this issue Nov 16, 2022
@cjellick
Revert "Merge client side and server side configs when installing (ac…
7bcf811 
…orn-io#790)"

This reverts commit 8ae67af.

Signed-off-by: Craig Jellick <craig@acorn.io>
cjellick added a commit that referenced this issue Nov 16, 2022
@cjellick
Merge pull request #886 from cjellick/revert-config-merge
904f587 
Revert "Merge client side and server side configs when installing (#790)"
@cjellick cjellick modified the milestones: v0.4.0, v0.4.1 Nov 17, 2022
@jsilverio22 jsilverio22 self-assigned this Nov 21, 2022
@jsilverio22 jsilverio22 mentioned this issue Nov 21, 2022
Closed
@cjellick cjellick mentioned this issue Nov 28, 2022
Merged
@cjellick cjellick assigned cjellick and unassigned jsilverio22 Nov 28, 2022
@tylerslaton
Copy link
Contributor

Validated locally.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cjellick cjellick

Labels
good first issue Good for newcomers kind/bug Something isn't working
Projects
None yet
Milestone
v0.4.1
Development

No branches or pull requests
4 participants
@ibuildthecloud @cjellick @tylerslaton @jsilverio22