Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Include storage class details in cli acorn volumes (#1229) #1241

Merged
merged 1 commit into from
Feb 18, 2023
Merged

Include storage class details in cli acorn volumes (#1229) #1241

merged 1 commit into from
Feb 18, 2023

Conversation

jacobdonenfeld
Copy link
Contributor

@jacobdonenfeld jacobdonenfeld commented Feb 17, 2023 •
edited
Loading

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in paranthesis, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keyworkds that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description

Closes #1229

@jacobdonenfeld jacobdonenfeld self-assigned this Feb 17, 2023
@jacobdonenfeld jacobdonenfeld changed the title include storage class details in cli acorn volumes (#1229) Include storage class details in cli acorn volumes (#1229) Feb 17, 2023
thedadams
thedadams reviewed Feb 17, 2023
View reviewed changes
@jacobdonenfeld
include storage class details in cli acorn volumes
a8eecfc 
Signed-off-by: jacobdonenfeld <jedonenfeld@gmail.com>
@jacobdonenfeld jacobdonenfeld force-pushed the include-storage-class-details-in-acorn-volumes branch from 792ba87 to a8eecfc Compare February 18, 2023 00:53
@jacobdonenfeld jacobdonenfeld merged commit 728c152 into acorn-io:main Feb 18, 2023
@jacobdonenfeld jacobdonenfeld deleted the include-storage-class-details-in-acorn-volumes branch February 18, 2023 04:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thedadams thedadams thedadams approved these changes

@sangee2004 sangee2004 Awaiting requested review from sangee2004

@tylerslaton tylerslaton Awaiting requested review from tylerslaton

@jsilverio22 jsilverio22 Awaiting requested review from jsilverio22

Assignees

@jacobdonenfeld jacobdonenfeld

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include storage class details in acorn volumes
2 participants
@jacobdonenfeld @thedadams