This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Add pre-stop hooks for containers that expose ports #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
commented
Oct 26, 2023
thedadams
force-pushed
the
pre-stop-hook
branch
2 times, most recently
from
26414ff to
eb79e20
Compare
|
Putting this up for review. I tested it with a |
thedadams
requested review from
ibuildthecloud,
njhale,
StrongMonkey,
g-linville and
tylerslaton
|
https://github.com/acorn-io/manager/pull/1517 should be merged first so we can use the mirrored image. I am also open to doing something else with this image, but this seemed to be the easiest. |
thedadams
commented
Oct 26, 2023
thedadams
force-pushed
the
pre-stop-hook
branch
from
eb79e20 to
8c30034
Compare
njhale
reviewed
Oct 27, 2023
g-linville
approved these changes
Oct 27, 2023
pkg/controller/appdefinition/testdata/deployspec/pre-stop/stateful/input.yaml
Show resolved
Hide resolved
This pre-stop hook will simply wait for 5 seconds. In order to achieve this in the most general way, a configmap is mounted as a volume that has a very simply binary that sleeps for 5 seconds. It is done this way because this should work for any container images, including scratch. Wait is not applied for stateful containers, jobs, or containers with one replica. Signed-off-by: Donnie Adams <donnie@acorn.io>
thedadams
force-pushed
the
pre-stop-hook
branch
from
8c30034 to
b48a256
Compare
|
In addition to the above mentioned changes, I:
Re-requesting reviews for these reasons. |
g-linville
approved these changes
Oct 27, 2023
njhale
approved these changes
Oct 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pre-stop hook will simply wait for 5 seconds. In order to achieve this in the most general way, a configmap is mounted as a volume that has a very simply binary that sleeps for 5 seconds. It is done this way because this should work for any container images, including scratch.