This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
fix: credential secrets: avoid the race condition better (#2410) #2431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #2410
Turns out my previous PR to fix this race condition introduced another problem. I was previously waiting until all containers in the app were marked as Defined in their status before prompting the user to fill in the credential secret, but the containers will never be Defined if their
env
references anything inside of the secret, since the secret needs to be created first.This new approach is much better (shoutout to Mr. Thedadams for the solution). We bubble up the app that is returned from our Update and use that as the basis for the generation, and the user is prompted only one time as a result.
Checklist
This is a title (#1216)
. Here's an example